Updates to pipeline #279
Merged
Updates to pipeline #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricerisingalgorand
force-pushed
the
feature/circleciPipeline
branch
2 times, most recently
from
828a77e to
1c13405
Compare
bricerisingalgorand
force-pushed
the
feature/circleciPipeline
branch
from
e7e7d36 to
32deda3
Compare
bricerisingalgorand
requested review from
algochoi,
jasonpaulos,
algojack,
egieseke and
onetechnical
algochoi
approved these changes
Jan 26, 2022
| @@ -2533,7 +2533,7 @@ def verify(self, public_key): | |||
| try: | |||
| verify_key.verify(to_sign, base64.b64decode(self.sig)) | |||
| return True | |||
| except BadSignatureError: | |||
| except (BadSignatureError, ValueError): | |||
There was a problem hiding this comment.
Note: There was a change in pynacl that allows throwing a ValueError or TypeError in the verify function.
egieseke
approved these changes
Jan 26, 2022
jasonpaulos
approved these changes
Jan 26, 2022
workflows > jobs > commands
algojack
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update circleci job to use docker instead of vms for unit tests. Also updated the unit tests to fail when they fail