Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update reviewdog warning linter job #6175

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

cce
Copy link
Contributor

@cce cce commented Nov 19, 2024

Summary

Changes how the reviewdog warning linter is configured (to match flags used by the reviewdog errors linter); changes cache key for loading previous builds of golangci-lint; and updates the gosec exclude list.

Test Plan

Should reliably make reviewdog warnings report on all builds.

@cce cce changed the title CI: debug run for reviewdog warnings linter CI: update reviewdog warning linter job Nov 19, 2024
@cce cce force-pushed the reviewdog-warnings branch from 8648463 to c65c3a9 Compare November 19, 2024 20:43
@cce cce marked this pull request as ready for review November 19, 2024 20:53
gmalouf
gmalouf previously approved these changes Nov 19, 2024
@cce cce requested a review from onetechnical November 19, 2024 20:58
algorandskiy
algorandskiy previously approved these changes Nov 19, 2024
.github/workflows/reviewdog.yml Outdated Show resolved Hide resolved
.golangci-warnings.yml Show resolved Hide resolved
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.90%. Comparing base (db7f162) to head (3bed8af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6175      +/-   ##
==========================================
+ Coverage   51.87%   51.90%   +0.02%     
==========================================
  Files         639      639              
  Lines       85492    85492              
==========================================
+ Hits        44352    44375      +23     
+ Misses      38327    38308      -19     
+ Partials     2813     2809       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cce cce dismissed stale reviews from algorandskiy and gmalouf via 62ad8ee November 20, 2024 17:05
@cce cce requested review from algorandskiy and gmalouf November 20, 2024 17:05
@cce cce force-pushed the reviewdog-warnings branch from 62ad8ee to 3bed8af Compare November 20, 2024 17:07
@gmalouf gmalouf merged commit 0bc3d7e into algorand:master Nov 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants