Skip to content

Commit

Permalink
switch to "added" instead of "nofilter" for warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
cce committed Nov 20, 2024
1 parent f567965 commit 62ad8ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
-f=golangci-lint \
-name="Lint Warnings" \
-reporter=github-pr-check \
-filter-mode=nofilter \
-filter-mode=added \
-fail-on-error=true \
-level=warning
- name: Slack Notification
Expand Down
16 changes: 8 additions & 8 deletions .golangci-warnings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@ linters:
disable-all: true
enable:
- gosec
- partitiontest
# - partitiontest

linters-settings:
gosec: # Go 1.22 makes G601 irrelevant
excludes: [G101, G103, G104, G107, G115, G202, G301, G302, G303, G304, G306, G307, G404, G601]
custom:
partitiontest:
path: cmd/partitiontest_linter/plugin.so
description: This custom linter checks files that end in '_test.go', specifically functions that start with 'Test' and have testing argument, for a line 'partitiontest.ParitionTest(<testing arg>)'
original-url: github.com/algorand/go-algorand/cmd/partitiontest_linter
excludes: [G101, G103, G104, G107, G202, G301, G302, G303, G304, G306, G307, G404, G601]
# custom:
# partitiontest:
# path: cmd/partitiontest_linter/plugin.so
# description: This custom linter checks files that end in '_test.go', specifically functions that start with 'Test' and have testing argument, for a line 'partitiontest.ParitionTest(<testing arg>)'
# original-url: github.com/algorand/go-algorand/cmd/partitiontest_linter

severity:
default-severity: warning

issues:
# use these new lint checks on code since #2574
new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57
# new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57

# Disable default exclude rules listed in `golangci-lint run --help` (selectively re-enable some below)
exclude-use-default: false
Expand Down

0 comments on commit 62ad8ee

Please sign in to comment.