Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique abbreviated Commit IDs #238

Closed
ajoberstar opened this issue Jun 6, 2018 · 0 comments · Fixed by #248
Closed

Unique abbreviated Commit IDs #238

ajoberstar opened this issue Jun 6, 2018 · 0 comments · Fixed by #248
Labels
enhancement
Milestone
2.3.0

Comments

@ajoberstar
Copy link
Owner

A unique abbreviated commit ID can be retrieved with ObjectReader. That should be the default if no arguments are provided:

getAbbreviatedId() should return a 7 character or longer (as needed to be unique)
getAbbreviatedId(int) should retain the current behavior of just giving you the exact length you asked for

However, it may make sense to deprecate the int variant.
@ajoberstar ajoberstar added this to the 2.3.0 milestone Jun 6, 2018
@ajoberstar ajoberstar mentioned this issue Jun 6, 2018
Closed
@ajoberstar ajoberstar modified the milestones: 2.3.0, 3.0.0 Jul 3, 2018
ajoberstar added a commit that referenced this issue Jul 3, 2018
@ajoberstar
Ensure abbreviated commit IDs are unique
f00af1f 
JGit provides a method that ensures uniqueness. This is safer than the
old approach that just substringed. That option is still around, but
deprecated.

This fixes #238.
ajoberstar added a commit that referenced this issue Jul 4, 2018
@ajoberstar
Ensure abbreviated commit IDs are unique
21c5331 
JGit provides a method that ensures uniqueness. This is safer than the
old approach that just substringed. That option is still around, but
deprecated.

This fixes #238.
@ajoberstar ajoberstar mentioned this issue Jul 4, 2018
Merged
@ajoberstar ajoberstar modified the milestones: 3.0.0, 2.3.0 Jul 4, 2018
@martinmosegaard martinmosegaard mentioned this issue Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Ensure abbreviated commit IDs are unique ajoberstar/grgit
1 participant
@ajoberstar