Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an abbreviated commit hash in the build metadata #86

Closed
jco2641 opened this issue Jun 6, 2018 · 1 comment
Closed

Use an abbreviated commit hash in the build metadata #86

jco2641 opened this issue Jun 6, 2018 · 1 comment
Milestone

Comments

@jco2641
Copy link

jco2641 commented Jun 6, 2018

What is the rationale behind using the full commit hash in the insignificant versions, vs the abbreviated commit hash git provides?
As I understand it, the abbreviated hash will expose enough characters to ensure it is unambiguous for referring to a commit.

@ajoberstar
Copy link
Owner

This was partly based on the way Grgit's abbreviated hash is computed currently (it's just a straight substring). However, there is a more reliable option in JGit that I could use, so I've opened an issue (ajoberstar/grgit#238) to enhance that.

Given that improvement and the unlikelihood of even a 7 character hash having a collision, I'd be fine switching these to abbreviated ones. It would be more user friendly.

@ajoberstar ajoberstar changed the title Abbreviated commit hash? Use an abbreviated commit hash in the build metadata Jun 6, 2018
@ajoberstar ajoberstar added this to the 0.8.0 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants