Fix manifest excludes not being updated for the src layout relocation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Oct 6, 2024
bdraco
force-pushed
the
fix_manifest_excludes
branch
from
c4c8ef3 to
1cd4bfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 22 22
Lines 768 768
Branches 65 65
=======================================
Hits 672 672
Misses 68 68
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
force-pushed
the
fix_manifest_excludes
branch
from
1cd4bfd to
d155e70
Compare
webknjaz
reviewed
Oct 6, 2024
Comment on lines
-19
to
-20
| exclude propcache/*.so | ||
| exclude propcache/*.pyd |
There was a problem hiding this comment.
To summarize https://github.com/aio-libs/propcache/pull/29/files#r1789278897, keep excluding these, just adjust the paths.
There was a problem hiding this comment.
@bdraco I meant that the so/pyd lines should remain in the manifest file
|
Sorry about that, I processed that wrong. Fixed in #36 |
bdraco
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed .pyd and .so since we do distribute these files