Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt multidict C ext test implementation #25

Merged
merged 13 commits into from
Oct 6, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 6, 2024

What do these changes do?

Adds conftest facade for handling the C ext

Are there changes in behavior for the user?

no

Related issue number

#18

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (560c078) to head (10fcfdd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   85.98%   87.01%   +1.02%     
==========================================
  Files          20       21       +1     
  Lines         678      724      +46     
  Branches       50       58       +8     
==========================================
+ Hits          583      630      +47     
+ Misses         68       67       -1     
  Partials       27       27              
Flag Coverage Δ
CI-GHA 87.01% <100.00%> (+1.32%) ⬆️
MyPy 67.79% <49.72%> (-1.14%) ⬇️
OS-Linux 98.52% <98.22%> (-0.21%) ⬇️
OS-Windows 93.07% <93.49%> (+0.21%) ⬆️
OS-macOS 93.75% <93.49%> (-2.88%) ⬇️
Py-3.10.11 92.64% <92.30%> (-3.56%) ⬇️
Py-3.10.15 95.58% <97.04%> (-2.31%) ⬇️
Py-3.11.10 95.58% <97.04%> (-2.31%) ⬇️
Py-3.11.9 92.64% <92.30%> (-3.56%) ⬇️
Py-3.12.6 95.52% <97.04%> (-1.96%) ⬇️
Py-3.13.0-rc.3 95.52% <97.04%> (-1.96%) ⬇️
Py-3.8.10 92.98% <92.85%> (-3.22%) ⬇️
Py-3.8.18 95.94% <97.61%> (-1.95%) ⬇️
Py-3.9.13 92.61% <92.26%> (-3.59%) ⬇️
Py-3.9.20 95.57% <97.02%> (-2.32%) ⬇️
Py-pypy7.3.11 95.65% <97.02%> (+1.26%) ⬆️
Py-pypy7.3.16 95.21% <96.42%> (+0.82%) ⬆️
Py-pypy7.3.17 95.23% <96.44%> (+0.85%) ⬆️
VM-macos-latest 93.75% <93.49%> (-2.88%) ⬇️
VM-ubuntu-latest 98.52% <98.22%> (-0.21%) ⬇️
VM-windows-latest 93.07% <93.49%> (+0.21%) ⬆️
pytest 98.40% <98.22%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title Adapt multidict implementation Adapt multidict c ext test implementation Oct 6, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 6, 2024
pytest.ini Outdated Show resolved Hide resolved
src/propcache/_helpers_c.pyx Outdated Show resolved Hide resolved
@bdraco bdraco changed the title Adapt multidict c ext test implementation Adapt multidict C ext test implementation Oct 6, 2024
@bdraco bdraco force-pushed the extension_import_cleanup branch from cec680f to ea8189b Compare October 6, 2024 18:04
@bdraco bdraco force-pushed the extension_import_cleanup branch from b1bc31c to 6fd3877 Compare October 6, 2024 18:17
setup.cfg Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
bdraco and others added 2 commits October 6, 2024 13:58
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
MANIFEST.in Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review October 6, 2024 19:15
@bdraco bdraco merged commit 8a68f5a into master Oct 6, 2024
47 of 49 checks passed
@bdraco bdraco deleted the extension_import_cleanup branch October 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants