-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt multidict C ext test implementation #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 85.98% 87.01% +1.02%
==========================================
Files 20 21 +1
Lines 678 724 +46
Branches 50 58 +8
==========================================
+ Hits 583 630 +47
+ Misses 68 67 -1
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
changed the title
Adapt multidict implementation
Adapt multidict c ext test implementation
Oct 6, 2024
bdraco
added
the
bot:chronographer:skip
This PR does not need to include a change note
label
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
changed the title
Adapt multidict c ext test implementation
Adapt multidict C ext test implementation
Oct 6, 2024
bdraco
force-pushed
the
extension_import_cleanup
branch
from
October 6, 2024 18:04
cec680f
to
ea8189b
Compare
bdraco
force-pushed
the
extension_import_cleanup
branch
from
October 6, 2024 18:17
b1bc31c
to
6fd3877
Compare
webknjaz
reviewed
Oct 6, 2024
webknjaz
reviewed
Oct 6, 2024
webknjaz
reviewed
Oct 6, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
webknjaz
reviewed
Oct 6, 2024
webknjaz
reviewed
Oct 6, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds conftest facade for handling the C ext
Are there changes in behavior for the user?
no
Related issue number
#18