Add full proxy support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR gets the Kodi global proxy settings and then applies those to all invocations of requests. This is the first implementation that adds full proxy support. In the future I would like to add 2 additional features so that users can select between: - Use Kodi proxy settings (default) - Disable proxy support for this addon - Custom proxy settings (for this addon) The current PR implements the first (default) option.
|
@mediaminister @pietje666 Please review! PS I updated the wiki page with ideas, feedback welcome. |
|
While testing (easiest is to remove your default gateway when the proxy is in your local network) I discovered that streaminputhelper is not proxy-aware either. So DRM-enable content (i.e. live streams) fail to work because But our addon at least is using the proxy fully. |
dagwieers
force-pushed
the
proxy-support
branch
from
ccc1b45 to
64924de
Compare
dagwieers
force-pushed
the
proxy-support
branch
from
64924de to
4e610b7
Compare
This was referenced Mar 22, 2019
SOCKS proxy support requires the requests[socks] library which is currently unavailable on standard Kodi repositories.
dagwieers
force-pushed
the
proxy-support
branch
from
308934d to
0e5807b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the Kodi global proxy settings and then applies those to
all invocations of requests.
This PR also prefixes log messages using
[plugin.video.vrt.nu]so it is clear where log messages are coming from.This is the first implementation that adds full proxy support.
In the future I would like to add 2 additional features so that users
can select between:
The current PR implements the first (default) option.