Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add proxy support #50

Closed
dagwieers opened this issue Mar 22, 2019 · 3 comments · Fixed by #51
Closed

[Enhancement] Add proxy support #50

dagwieers opened this issue Mar 22, 2019 · 3 comments · Fixed by #51
Milestone

Comments

@dagwieers
Copy link
Collaborator

While testing our own addon's proxy support I discovered that inputstreamhelper does not adhere to Kodi's proxy configuration, which breaks playing DRM streams.

It is not that hard to make addon's using Requests to use Kodi's proxy settings. You can find our implementation at: add-ons/plugin.video.vrt.nu#87

The testing methodology I used was to disable the default gateway (or in LibreELEC, configure a non-existing gateway) and then test your local proxy and see if everything works as expected.

@dagwieers dagwieers changed the title Add proxy support [Enhancement] Add proxy support Mar 22, 2019
@emilsvennesson
Copy link
Owner

Hi!

Is there any actual explanation why this is needed to be done by the add-on? You would assume that Kodi would use its proxy settings system wide, because I can imagine that there's a lot of add-on that won't handle this proxy stuff themselves.

@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 23, 2019

Well, everything that uses internal functionality (like ListItem) does use global Kodi settings, but you are using the python Requests library independently, and it doesn't know about Kodi's proxy settings.

PR #51 gets Kodi's proxy settings and applies them to your requests-invocation.

And indeed, there are quite some addon's that do not have (full) proxy support (netflix, youtube, etc), or have their own proxy support (retrospect). Or our own vrt.nu addon which did use Kodi's proxy for everything that was handled by Kodi, but not for the stuff that used the requests library.

@dagwieers
Copy link
Collaborator Author

BTW Feel free to configure a proxy in Kodi and test it yourself, your addon will not be using the Kodi proxy. So DRM playback will simply fail in environments that require a proxy to be used.

@dagwieers dagwieers added this to the 0.4.0 milestone Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants