Remove upper bound dependency limits from gemspec #711
Conversation
rafaelfranca
force-pushed
the
drop-upper-bound
branch
3 times, most recently
from
9a8d34b to
981d576
Compare
rafaelfranca
changed the title
There was a problem hiding this comment.
Thanks @rafaelfranca! I understand the reasoning and am ok with either removing or specifying upper bounds. Why did you remove the gemspec_lint test? That would help us confirm no warnings. Other than thought no concerns with the change. There are merge conflicts.
I removed because RubyGems show warnings for dependencies without upper bound. I wish I could just disable that warning so we could checking the others, but that is not the case |
rafaelfranca
force-pushed
the
drop-upper-bound
branch
from
981d576 to
2d0b534
Compare
|
I agree with your reasoning too @rafaelfranca. I would like to work on making RubyGems gemspec warnings configurable in the future. But for now it seems easy enough to ignore this particular warning from the output, instead of removing everything? I'm happy to work on it myself if you don't have the time. |
|
You mean in the test? I can totally do it. I'll update the PR to ignore just that warning. |
|
Yes, in the test I mean. |
All that was needed to support Rails 7 in this gem was to update the gemspec. This means that even in the most likely release to break anything, a major release, we didn't needed to worry about breaking this gem. This upper bound is just creating unnecessary work for the maintainers of this gem, which would need to release it without any code change, and the users, which need to open issues asking for new releases. Let's allow our users to try any version of our dependencies and report real issues if they find them, and save everyone's time just removing the upper bound.
javierjulio
force-pushed
the
drop-upper-bound
branch
from
2d0b534 to
1424154
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 14 14
Lines 555 555
=======================================
Hits 545 545
Misses 10 10 ☔ View full report in Codecov by Sentry. |
javierjulio
changed the title
javierjulio
changed the title
All that was needed to support Rails 7 in this gem was to update the
gemspec. This means that even in the most likely release to break
anything, a major release, we didn't needed to worry about breaking this
gem.
This upper bound is just creating unnecessary work for the
maintainers of this gem, which would need to release it without any code
change, and the users, which need to open issues asking for new releases.
Let's allow our users to try any version of our dependencies and report
real issues if they find them, and save everyone's time just removing
the upper bound.