Remove upper bound limit from our dependencies

All that was needed to support Rails 7 in this gem was to update the gemspec. This means that even in the most likely release to break anything, a major release, we didn't needed to worry about breaking this gem. This upper bound is just creating unnecessary work for the maintainers of this gem, which would need to release it without any code change, and the users, which need to open issues asking for new releases. Let's allow our users to try any version of our dependencies and report real issues if they find them, and save everyone's time just removing the upper bound.
activeadmin · Jan 19, 2022 · 981d576 · 981d576
1 parent a0a3502
commit 981d576
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 50 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -29,9 +29,6 @@ jobs:
       - name: Make sure gemfiles are up to date
         run: ruby -Itest -rbundler/setup -rgemfiles/lint -e 'exit(Minitest.run)'
 
-      - name: Make sure gemspec builds without warnings
-        run: ruby -Itest -rbundler/setup -rgemfiles/gemspec_lint -e 'exit(Minitest.run)'
-
       - name: Run linters
         run: bin/rubocop
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -2,10 +2,10 @@ PATH
   remote: .
   specs:
     inherited_resources (1.13.0)
-      actionpack (>= 5.2, < 7.1)
-      has_scope (~> 0.6)
-      railties (>= 5.2, < 7.1)
-      responders (>= 2, < 4)
+      actionpack (>= 5.2)
+      has_scope (>= 0.6)
+      railties (>= 5.2)
+      responders (>= 2)
 
 GEM
   remote: https://rubygems.org/
@@ -217,4 +217,4 @@ DEPENDENCIES
   rubocop
 
 BUNDLED WITH
-   2.2.31
+   2.2.32
diff --git a/inherited_resources.gemspec b/inherited_resources.gemspec
@@ -21,8 +21,8 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = '>= 2.5'
 
-  s.add_dependency("responders", ">= 2", "< 4")
-  s.add_dependency("actionpack", ">= 5.2", "< 7.1")
-  s.add_dependency("railties", ">= 5.2", "< 7.1")
-  s.add_dependency("has_scope",  "~> 0.6")
+  s.add_dependency("responders", ">= 2")
+  s.add_dependency("actionpack", ">= 5.2")
+  s.add_dependency("railties", ">= 5.2")
+  s.add_dependency("has_scope",  ">= 0.6")
 end
diff --git a/test/gemfiles/gemspec_lint.rb b/test/gemfiles/gemspec_lint.rb
diff --git a/test/rails_52/Gemfile.lock b/test/rails_52/Gemfile.lock
@@ -2,10 +2,10 @@ PATH
   remote: ../..
   specs:
     inherited_resources (1.13.0)
-      actionpack (>= 5.2, < 7.1)
-      has_scope (~> 0.6)
-      railties (>= 5.2, < 7.1)
-      responders (>= 2, < 4)
+      actionpack (>= 5.2)
+      has_scope (>= 0.6)
+      railties (>= 5.2)
+      responders (>= 2)
 
 GEM
   remote: https://rubygems.org/

diff --git a/test/rails_60/Gemfile.lock b/test/rails_60/Gemfile.lock
@@ -2,10 +2,10 @@ PATH
   remote: ../..
   specs:
     inherited_resources (1.13.0)
-      actionpack (>= 5.2, < 7.1)
-      has_scope (~> 0.6)
-      railties (>= 5.2, < 7.1)
-      responders (>= 2, < 4)
+      actionpack (>= 5.2)
+      has_scope (>= 0.6)
+      railties (>= 5.2)
+      responders (>= 2)
 
 GEM
   remote: https://rubygems.org/

diff --git a/test/rails_61/Gemfile.lock b/test/rails_61/Gemfile.lock
@@ -2,10 +2,10 @@ PATH
   remote: ../..
   specs:
     inherited_resources (1.13.0)
-      actionpack (>= 5.2, < 7.1)
-      has_scope (~> 0.6)
-      railties (>= 5.2, < 7.1)
-      responders (>= 2, < 4)
+      actionpack (>= 5.2)
+      has_scope (>= 0.6)
+      railties (>= 5.2)
+      responders (>= 2)
 
 GEM
   remote: https://rubygems.org/

diff --git a/test/rails_70/Gemfile.lock b/test/rails_70/Gemfile.lock
@@ -2,10 +2,10 @@ PATH
   remote: ../..
   specs:
     inherited_resources (1.13.0)
-      actionpack (>= 5.2, < 7.1)
-      has_scope (~> 0.6)
-      railties (>= 5.2, < 7.1)
-      responders (>= 2, < 4)
+      actionpack (>= 5.2)
+      has_scope (>= 0.6)
+      railties (>= 5.2)
+      responders (>= 2)
 
 GEM
   remote: https://rubygems.org/
@@ -196,4 +196,4 @@ DEPENDENCIES
   rails-controller-testing
 
 BUNDLED WITH
-   2.2.31
+   2.2.32