ENHANCE: Use pylint for Surround's linter #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zacbrannelly
commented
Oct 24, 2019
•
zacbrannelly
commented
- Rip out previous linter and replace with Pylint
- Setup default disabled messages and fix generated projects
zacbrannelly
changed the title
zacbrannelly
force-pushed
the
enhance/pylint
branch
from
768ff52 to
4ec995a
Compare
mpej
approved these changes
Nov 14, 2019
zacbrannelly
force-pushed
the
enhance/pylint
branch
from
4ec995a to
3786222
Compare
zacbrannelly
force-pushed
the
enhance/pylint
branch
from
3786222 to
db7d45a
Compare
ucokzeko
requested changes
Nov 18, 2019
There was a problem hiding this comment.
@zacbrannelly Can you please rebase this again? Sorry
I also got this issue from generating this project from this PR
✔ ~/A2I2/Code/temp/linter_test
09:24 $ surround lint
************* Module dodo
dodo.py:129:0: C0301: Line too long (106/100) (line-too-long)
dodo.py:165:0: C0301: Line too long (106/100) (line-too-long)
------------------------------------------------------------------
Your code has been rated at 9.91/10 (previous run: 9.91/10, +0.00)
added 9 commits
November 19, 2019 10:10
Due to rebasing
zacbrannelly
force-pushed
the
enhance/pylint
branch
from
51cd79b to
c40b56c
Compare
|
@ucokzeko Fixed and added a test case to check for linter errors in the generated project |
ucokzeko
reviewed
Nov 19, 2019
There was a problem hiding this comment.
@zacbrannelly Is it possible to run the same Pylint version that we use from requirement.txt and the version that we install in CircleCi when we run the test? Try to find a way to install it from 1 source instead of updating the version in the config file.
|
@ucokzeko Yeah I just removed installing pylint from the CircleCI config, this way it will just use the version that is in the requirements.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.