Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCE: Add custom check for print statements #209

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

zacbrannelly
Copy link
Collaborator

@zacbrannelly zacbrannelly commented Oct 28, 2019

Surround Linter throws error when print() is used in the project

@zacbrannelly zacbrannelly force-pushed the enhance/custom-checkers branch from 33c21f5 to f60fc46 Compare October 29, 2019 22:51
@mpej
Copy link

mpej commented Nov 13, 2019

Linter successfully throws error when print statements are added to project.

@zacbrannelly zacbrannelly force-pushed the enhance/custom-checkers branch 9 times, most recently from a2b5f0d to 5e47737 Compare November 19, 2019 02:12
@ucokzeko
Copy link
Member

@zacbrannelly Can you rebase this please? Thanks

@zacbrannelly zacbrannelly force-pushed the enhance/custom-checkers branch from 5e47737 to 6c65ee4 Compare November 19, 2019 02:35
@zacbrannelly
Copy link
Collaborator Author

@ucokzeko Done 👍

Copy link
Member

@ucokzeko ucokzeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ucokzeko ucokzeko merged commit 7ee804a into a2i2:master Nov 19, 2019
@zacbrannelly zacbrannelly deleted the enhance/custom-checkers branch November 19, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants