Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Softmax integration #1155

Open
wants to merge 59 commits into
base: feature/prefix_node_names
Choose a base branch
from
Open

Softmax integration #1155

wants to merge 59 commits into from
+1,109 −12

Conversation

azizb-xlnx
Copy link
Collaborator

Integrate HLS Softmax

aziz bahri added 30 commits August 8, 2024 17:47
softmax: add initial test harness
b49a8cb
softmax: stub class an infersoftmax
3caff12
softmax: stub abstract methods
735ed84
softmax: input image dimension attribute
27f35ff
softmax: use input img dimension to build input shape
e731727
softmax: softmax on inner dim
1326657
softmax: infer softmax helper implementation
8befea8
softmax: hls class stub
ef42207
softmax: extend test to apply folding config
3c41cf2
softmax: add Quant to node name
5264869
softmax: generate hls code
bbcc6ea
softmax: use sname for input name
2653d36
softmax: quantsoftmax replaces softmax+multithreshold
178a9d0
softmax: run stitchedip
73e7244
softmax: hls execute softmax bin
11b19cb
softmax: include correct imports
5faca11
softmax: set preferred impl style
8d9b9fd
finn: add hls library paths
ac22ecb
cpp compiler: raise exception if compilation fails
e6d3d3a
softmax: compile node for cpp sim
2a03747
softmax: generate cppsim code
a87fc03
softmax: does not suppor rtlsim
ccf6842
softmax: transformation test
ed84da1
softmax: more generic testcase
f1e4b46
hlsbackend: handle subprocess exceptions and log them
fc0e5db
cpp template: try catch in cppsim templates
11f9f0c
softmax: generate cppsim with npyvector stream
afa050f
softmax: functional model
ccd5c57
softmax: clean up prints
9c312e0
softmax: clear up functional test
c076723
@azizb-xlnx azizb-xlnx requested a review from auphelia August 8, 2024 16:52
@azizb-xlnx azizb-xlnx marked this pull request as ready for review August 8, 2024 16:52
aziz bahri and others added 24 commits August 12, 2024 15:28
softmax: cpp sim stream size check
a1c6857
softmax: fix expected stream size
99e2f19
softmax: add debug prints into testbench
f806909
softmax: simplify testcase
08a73aa
entrypoint: only add necessary libs to path
27f36f9
entrypoint: fail if xrt not found
c4d2690
softmax: move hls source to custom hls directory
7274a8b
softmax: quantization fix
12cc01b
softmax: add softmax transform to dataflow step
96c4c65
softmax: make softmax shape agnostic
f8715b6
softmax: make softmax shape agnostic 2
ef1b7f5
@STFleming
Adding input/output datatype parameters to the softmax node rather th…
4ff7fc8 
…an assuming that they are the same
@STFleming
first cut and adding separate In/Out type template params for quantso…
9eb9f1b 
…ftmax
@STFleming
Output datatype is now passing tests
01411cc
@STFleming
Added an additional test for a different output type (which is passing)
052ef46
@STFleming
Added INT9 Input test case
a295bdc
@STFleming
Fixing test, thanks @auphelia
f5d1bfc
@auphelia
Merge pull request #1166 from STFleming/feature/sm_integration
640f81f 
Separate Input/Output datatype template parameters
@auphelia
[QuantSoftMax] Clean up setting of output data type
1414e7e
@STFleming
Added rounding mode to avoid the default truncation rounding.
5d5bee9
@auphelia
Merge pull request #1180 from STFleming/feature/sm_integration
1ebe02f 
Added rounding mode to avoid the default truncation rounding in the last stage of the QuantSoftMax HLS pipeline.
@STFleming
Fixed is_signed detection for ap_int types
16ec172
@STFleming
Merge branch 'feature/sm_integration' of github.com:STFleming/finn in…
ef4000b 
…to feature/sm_integration
@auphelia
Merge pull request #1196 from STFleming/feature/sm_integration
f54d050 
Fix is_signed detection for ap_int and ap_uint types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auphelia auphelia Awaiting requested review from auphelia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azizb-xlnx @STFleming @auphelia