Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Input/Output datatype template parameters #1166

Merged

Conversation

STFleming
Copy link
Collaborator

This PR updates the softmax integration to include the ability to specify input and output template datatype parameters separately.

The main changes are:

  • Updated to the HLS code to enable the specification of the separate templates for input/output.
  • Compiler integration to enable the inference of the output data types and appropriate codegen.
  • Test updates to allow the specification of different input/output datatypes.

I have only tested the quantsoftmax node with the following:

tests/fpgadataflow/test_fpgadataflow_softmax.py::test_fpga_dataflow_quantsoftmax[ifm_dim0-INT8-INT8-simd4-hls] PASSED
tests/fpgadataflow/test_fpgadataflow_softmax.py::test_fpga_dataflow_quantsoftmax[ifm_dim1-INT8-INT8-simd4-hls] PASSED

@STFleming
Copy link
Collaborator Author

Added an additional output type test which seems to be working okay.

tests/fpgadataflow/test_fpgadataflow_softmax.py::test_fpga_dataflow_quantsoftmax[ifm_dim1-INT8-INT16-simd4-hls] PASSED

@auphelia auphelia merged commit 640f81f into Xilinx:feature/sm_integration Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants