Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed feedback buttons' layout breaking in different languages, in newsletters #21752

Merged
merged 5 commits into from
Dec 2, 2024
Merged

🐛 Fixed feedback buttons' layout breaking in different languages, in newsletters #21752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c347673
Updated feedback buttons styling in newsletters
dvdwinden Nov 28, 2024
b04b9a7
Added word-break to feedback buttons in email
dvdwinden Nov 28, 2024
b99cb15
Revert translation changes
dvdwinden Nov 28, 2024
a884ac3
Updated snapshots
dvdwinden Nov 28, 2024
1b08b27
Updated snapshots (e2e)
dvdwinden Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 10 additions & 25 deletions ghost/core/test/e2e-api/admin/__snapshots__/email-previews.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,7 @@ table.body .footer a {
}

table.body .feedback-button-text {
display: block !important;
padding-top: 4px !important;
padding-left: 0px !important;
font-size: 13px !important;
display: none!important;
}

table.body .latest-posts-header {
Expand Down Expand Up @@ -782,7 +779,7 @@ exports[`Email Preview API Read can read post email preview with email card and
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "24870",
"content-length": "24766",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down Expand Up @@ -1018,10 +1015,7 @@ table.body .footer a {
}

table.body .feedback-button-text {
display: block !important;
padding-top: 4px !important;
padding-left: 0px !important;
font-size: 13px !important;
display: none!important;
}

table.body .latest-posts-header {
Expand Down Expand Up @@ -1500,7 +1494,7 @@ exports[`Email Preview API Read can read post email preview with fields 4: [head
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "29650",
"content-length": "29546",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down Expand Up @@ -1767,10 +1761,7 @@ table.body .footer a {
}

table.body .feedback-button-text {
display: block !important;
padding-top: 4px !important;
padding-left: 0px !important;
font-size: 13px !important;
display: none!important;
}

table.body .latest-posts-header {
Expand Down Expand Up @@ -2234,7 +2225,7 @@ exports[`Email Preview API Read has custom content transformations for email com
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "24624",
"content-length": "24520",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down Expand Up @@ -2830,10 +2821,7 @@ table.body .footer a {
}

table.body .feedback-button-text {
display: block !important;
padding-top: 4px !important;
padding-left: 0px !important;
font-size: 13px !important;
display: none!important;
}

table.body .latest-posts-header {
Expand Down Expand Up @@ -3311,7 +3299,7 @@ exports[`Email Preview API Read uses the newsletter provided through ?newsletter
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "25407",
"content-length": "25303",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down Expand Up @@ -3933,10 +3921,7 @@ table.body .footer a {
}

table.body .feedback-button-text {
display: block !important;
padding-top: 4px !important;
padding-left: 0px !important;
font-size: 13px !important;
display: none!important;
}

table.body .latest-posts-header {
Expand Down Expand Up @@ -4414,7 +4399,7 @@ exports[`Email Preview API Read uses the posts newsletter by default 4: [headers
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "25407",
"content-length": "25303",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down
Loading