🐛 Fixed feedback buttons' layout breaking in different languages, in newsletters #21752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdwinden
force-pushed
the
feedback-comment-email-fix
branch
2 times, most recently
from
db12297 to
55ead35
Compare
It now won't break the layout in different translations.
dvdwinden
force-pushed
the
feedback-comment-email-fix
branch
from
b1b29d9 to
a884ac3
Compare
|
closes #21700 . |
Thank you, @cathysarisky. We had another issue for this internally, and I hadn't yet flagged it here. Fix is awaiting review, and will go out early this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/ghost/issue/DES-974/feedback-and-comment-icons-when-translated-cause-overlapping-in-email
Before
After
