-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvement in performance and reliability #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your hard work ! Since I see you commit over the time, tell me when you feel this can be merged. |
I have finished all of what I think need to improve, please merge it. Broken Changes and Attention
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve endian convert method
Use
IPAddress.HostToNetworkOrder
insead.Use absolute path
Imagine that when open terminal from other directory not contains
GICutscenes.exe
, the program cannot find fileappsettings.json
andversions.json
. Use absolute path to solve this problem.Add command to reset appsettings.json
If
appsettings.json
is accidentally damaged or changed section name, program throw exception at the first time. So I made some changes:appsettings.json
to defaultGICutsences.exe reset
Handle Exception
Showing stack trace when throw exception is unnecessary, and it occupies a large space in the terminal. I added an option and exception handler to define whether shows it.
Comparison:
Update Command
#28
Use
GICutscenes.exe update
to downloadversions.json
and check update for program. Comparing program'sAssemblyVerison
and tag name of the latest release, skip the first character of tag name.Critical code:
And there are two options of update command:
-nb
, do not open bowser if there's new version-p
, specifies a proxy server for the requestSupport Encoding Format when Merge into mkv
#55
Custom Subtutles Style
#41
Add
SubsStyle
node to appSettings.json, default isThe converted ass subs will be saved in
{outputPath}/Subs/
and deleted after task if no--no-cleanup
.