Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hope it can edit ffmpeg options #19

Closed
Unknow-404 opened this issue Jul 8, 2022 · 8 comments
Closed

Hope it can edit ffmpeg options #19

Unknow-404 opened this issue Jul 8, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@Unknow-404
Copy link

Will the next version support edit fffmpeg options?

@ToaHartor
Copy link
Owner

Can you give me some examples and use cases ? I don't know ffmpeg well enough to see if some could require a special treatment.

However I can see some ways of doing that (within the config file and directly in the command line)

@Unknow-404
Copy link
Author

Unknow-404 commented Jul 8, 2022

Can you give me some examples and use cases ? I don't know ffmpeg well enough to see if some could require a special treatment.

However I can see some ways of doing that (within the config file and directly in the command line)

I modified line 105 of [src/Mergers/FFMPEG.cs] file again and built the client, which will convert the extracted video to H.264 encoding and audio to AAC encoding.

@Unknow-404
Copy link
Author

Unknow-404 commented Jul 8, 2022

Can you give me some examples and use cases ? I don't know ffmpeg well enough to see if some could require a special treatment.
However I can see some ways of doing that (within the config file and directly in the command line)

I modified line 105 of [src/Mergers/FFMPEG.cs] file again and built the client, which will convert the extracted video to H264 encoding and audio to AAC encoding.

_command += $" -vcodec libx264 -acodec aac -ab 256k \"{_output}\"";

@Unknow-404
Copy link
Author

Unknow-404 commented Jul 8, 2022

If I directly copy the source coding (VP9), there will be a splash screen when playing.

@Unknow-404
Copy link
Author

The reason why I want to re encode the video is that using H.264 and AAC encoding can make the video play on most devices.

@Unknow-404
Copy link
Author

Thanks for your reply!

@ToaHartor
Copy link
Owner

Alright so encoding options can be inserted at the end of the command. I don't think I will filter and list which option can be entered there, but I can add an option to give the freedom to insert additional parameters to ffmpeg. This could also be coupled with #17 and can be added to the next release as part of the CLI improvements.

@ToaHartor
Copy link
Owner

Added in the PR #57 as command arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants