Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ledger): avoid rocksdb segfault #438

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix(ledger): avoid rocksdb segfault #438

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24ea6a0
fix(ledger): avoid rocksdb segfault
dnut Dec 13, 2024
a49650c
Merge branch 'main' into dnut/fix/rocksdb-segfault
dnut Dec 13, 2024
66bc65b
Merge branch 'main' into dnut/fix/rocksdb-segfault
dnut Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ pub fn build(b: *Build) void {
const curl_dep = b.dependency("curl", dep_opts);
const curl_mod = curl_dep.module("curl");

const rocksdb_dep = b.dependency("rocksdb", dep_opts);
const rocksdb_dep = b.dependency("rocksdb", .{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, if building a dependency in a different release mode like this won't also lead to some other issues?

.target = target,
// this avoids a bug where rocksdb segfaults when built in ReleaseSafe
.optimize = if (optimize == .ReleaseSafe) .ReleaseFast else optimize,
});
const rocksdb_mod = rocksdb_dep.module("rocksdb-bindings");

const lsquic_dep = b.dependency("lsquic", dep_opts);
Expand Down
Loading