fix(ledger): avoid rocksdb segfault #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadepo
reviewed
Dec 13, 2024
| @@ -46,7 +46,11 @@ pub fn build(b: *Build) void { | |||
| const curl_dep = b.dependency("curl", dep_opts); | |||
| const curl_mod = curl_dep.module("curl"); | |||
|
|
|||
| const rocksdb_dep = b.dependency("rocksdb", dep_opts); | |||
| const rocksdb_dep = b.dependency("rocksdb", .{ | |||
There was a problem hiding this comment.
I think this is fine, if building a dependency in a different release mode like this won't also lead to some other issues?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 66bc65b | Previous: b0e35a0 | Ratio |
|---|---|---|---|
benchmarkGossipService(1k_pull_resp_msgs) |
6284793 nanos |
852137 nanos |
7.38 |
BlockstoreReader.getDataShredsForSlot(_) |
155732 nanos |
53791 nanos |
2.90 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A segfault occurs in RocksDB when built in ReleaseSafe. This can be reproduced with a minimal example of code that only depends on the C library. It does not segfault when RocksDB is built using cmake. It does not segfault in any other zig optimize mode.
This PR is a quick fix to avoid the segfault by preventing RocksDB from being built by zig with ReleaseSafe. Whenever ReleaseSafe is specified as the build mode, RocksDB will be built with ReleaseFast. Otherwise it will use the same optimize mode as the build as a whole.