Should exit with a non-zero error code on fatal error #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there's a bunch of different conditions in `func main()` which cause an immediate `return` (exit) because of an error that was encountered. On golang, returning the main function causes the program to exit status code 0 (success). Rather than indicate success, failures should exit with a non-zero code so that process managers can recognise it as a failure and do something appropriate (e.g. restart if the error condition is transient). Signed-off-by: Andrew Rowson <[email protected]>
SuperQ
added a commit
that referenced
this pull request
May 23, 2022
* [CHANGE] Exit with a non-zero error code on fatal error #70 * [FEATURE] Add TLS/Auth from exporter-toolkit #69 Misc: * Update build to Go 1.18. * Bump Go modules. * Enable dependabot. * Sync upstream Prometheus Makefile.common. Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's a bunch of different conditions in
func main()which cause an immediatereturn(exit) because of an error that was encountered. On golang, returning the main function causes the program to exit status code 0 (success). Rather than indicate success, failures should exit with a non-zero code so that process managers can recognise it as a failure and do something appropriate (e.g. restart if the error condition is transient).