Add HTTPS support #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be done with the exporter-toolkit. |
SuperQ
reviewed
May 6, 2022
|
This needs a DCO sign-off. You can use Please also squash the commits. |
Signed-off-by: Yuriy Kis <[email protected]> Add HTTPS support Signed-off-by: Yuriy Kis <[email protected]> Add tls config to README Signed-off-by: Yuriy Kis <[email protected]> Remove unnecessary params from target group Signed-off-by: Yuriy Kis <[email protected]>
|
Squashed commits and added DCO sign-off |
SuperQ
added a commit
that referenced
this pull request
May 23, 2022
* [CHANGE] Exit with a non-zero error code on fatal error #70 * [FEATURE] Add TLS/Auth from exporter-toolkit #69 Misc: * Update build to Go 1.18. * Bump Go modules. * Enable dependabot. * Sync upstream Prometheus Makefile.common. Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just added the ability to run the exporter on the HTTPS server. If it's better to do it some other way, please let me know