-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this is me trying to follow your example @fbmnds #124
Conversation
You can run: rake docs:api_quick to get the error message.
Compilation errors: - (0, 0) Assuming assembly reference `FSharp.Core, Version=4.3.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' matches assembly `FSharp.Core, Version=4.3.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. You may need to supply runtime policy
@@ -128,8 +129,42 @@ namespace :docs do | |||
end | |||
end | |||
|
|||
task :fsformatting do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you clean this directory or is it overwritten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NuGet packages are 'immutable' not overwritten at all, just not re-downloaded after nuget verifies they are there.
cp_r overwrites files, yes, every time.
I need to think about it. Currently, the rationale is as follows:
|
I don't know what artefact I changed then. I just installed latest mono and I got my path linked with that. I can try this on linux too if you want. |
Same error. Not about the environment then. |
If you clone this repo, checkout this branch you can create another PR and it will build automatically on the TC server -- that allows you to test anything without having me to do the typing. Just like last time, I have to move onto actual work now. I hope that the tool can be fixed so that it works. |
your mono is based on net40, but FSharp.Formatting is compiled against net45 - I assume, checking... |
yes, but only the commandline tool, not the other parts of the library - let me check, what options we have |
Compiled with mono 3.4:
So the same. It's probably the F# dll that has the issue.
|
I successfully built FSharp.Formatting with commandline tool on net40. This should be a PR to FSharp.Formatting as there was a similar issue already in the past. |
see here:
It is again the search path issue. I´ll try with a PR as you describe above. |
Leaving the office in 9 min. However, the absolute path helped. Now I only have the policy error left. Nuget |
I do no see a need to install fsharp.core for the commandline tool. It brings all necessary dlls with it. I find this confusing. |
I think the problem is that mono has F# 4.3.0.0 and you have compiled this tool against 4.3.1.0. That's why suave hasn't upgraded F# version. |
this makes sense. |
|
EOD (end of day, time for squash). |
doesn´t work because of previous, unrelated error:
|
You are right, the mono upgrade destroyed the tests... Another yak. If I were to continue debugging this, I would 1) create a build on tc that doesn't run all tests so we can continue playing around, 2) look into the policy file in the nuget I mentioned and try and add that to the tool, 3) go through all dependencies of all the dlls in that folder, transitively, and with dotPeek verify they are not linked to F# 4.3.1.0, 4) rebuild from source with correct F# linked. |
Refering to your points:
|
My summary of the options so far:
|
|
||
task :fsformatting do | ||
nuget_install 'FSharp.Core.Open.FS31' | ||
nuget_install 'FSharp.Formatting.CommandTool' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbmnds This is the only reference to the tool; a NuGet.exe install
command.
Still not working with new version:
|
You can run:
rake docs:api_quick
to get the error message.