CommandLine tool doesn't find dll, FAKE tool fails with InvalidOperationException #167
Comments
|
Using this library is really confusing: |
|
Ok, continuing trying to make it work, getting further: At commit 1b112a2, F# 3.1 on mono 3.4.0, on this line of code: This doesn't look like it's something that can fail: GeneratedSequenceBase must be something in the compiler? |
haf
changed the title
|
This is pretty confusing. I'm a bit busy at the moment (you should be able to build FSharp.Fomratting from source and debug this), but if you can upload the DLL somewhere, I'll have a look when I'm a bit more free! |
|
https://github.com/logary/logary#building and then: Should work on all three platforms. Ok, I'll compile Formatting and have a look then. I just wish I could have spent these hours writing docs instead :( (not saying what you're doing isn't awesome, because it is, but still this is the way I feel right now) |
|
Corresponding Windows stack trace: |
|
Copying |
|
It can be worth noting that I'm trying to generate docs for a project on F# 3.0/.Net 4.0. |
|
I'm giving up, going to set up proper CI for my own project and actually write some docs. Tell me if I can be of service in any other way. |
|
This might be some issue with F# Compiler Service. Perhaps @dsyme would know? In any case, if you can give me a simple ZIP file with FSX to run and DLL to process, then I can easily test it, which would be great. I do not know anything about rake and it scares me :-) |
|
Any update on this? It would be great to get some documentation going? Is there anything I can help you with? I have sent an e-mail with the dll to you, and the instructions should be easy enough to follow if you prefer to build it yourself =). |
|
I finally tested this and it seems to work fine on my machine (using Windows and latest build of F# Formatting). Not sure what's going on here! Do you have |
|
|
|
I can try with the latest build, if the nuget isn't the latest. Otherwise, did you try with rake runner, or just running the fsx file? It could be that ruby is always 32bit and therefore launches a 32 bit CLR? |
|
Why does it complain that it can't find the name property? |
|
I assume that the indication of a compiler service error is just a subsequent fault within cascading errors. As @tpetricek already confirmed on 23. June, the formatting process basically works on one @haf: in your initial post of 6. June, the parameters on the commandline options are quoted. This may lead to nasty side effects depending on the quote evaluation logic of your OS/shell. [Update] see now that this creeped in via Fake. Not a good idea, @forki - if it were, you overlooked this. |
|
@haf while diggging deeper into the problem, I feel growing confidence that my assumption about the search path issue is more likely than a F# compiler service issue. While I did not find the Looking into Suave, I suggest to introduce in the project´s
only misses to define the parameter |
|
between @haf I think I encountered this issue in the past and found the cause; I was able then to generate docs for suave. I will see if I can locate that project. |
|
I found some bits from a year ago, I think MetadataFormat.Generate(@"C:\..\suave.dll", output_folder, [ template_file ]) |
|
Almost yes, as this will not work on your OS X server. In summary, you may want to consider the following points:
@tpetricek it may make sense that you address these points in some way in the documentation here(?). I could add the summary above in the commandline tool docs with reference to your doc. - The issue should be closed. |
|
Can we close this issue first when we have a working cross platform build, please? |
|
I cannot recommend to track configuration problems of your projects here. The decision is up to @tpetricek, of course. I am ready to assist you anyway, if wanted, here |
|
I see your point, however if the default flags are incorrect in what is 'required' and/or I can't point to a dll with a relative path, at least create one or two new issues for those problems? After all, the command line tool can't be used successfully by following its own output. However, today I'm back from vacation, so I'm ready to start playing around with your suggestions! On 28 jul 2014, at 07:51, fbmnds [email protected] wrote:
|
|
Be assured that this kind of reflection happens:
I agree that here are some design weeknesses. I see the following points // cc: @tpetricek, @forki:
I´ll keep an eye on your progress and give advice when requested. This will provide valuable user feedback for the tools. Currently I think, that a commented |
|
I'm always open to better solutions here - e.g. having documentation generation as an actual FAKE task would be nice. That said, if we can at least document the current behavior as @fbmnds suggests, than that would save people a lot of pain! So I'll certainly happily merge any additions to the documentation! |
|
@tpetricek w.r.t. better solutions, I suggest to depricate the commandline tool as the alternatives seem to be better (see extended doc). It might be a good idee to open an issue for discussion in order to get community response on this. |
|
Also, may I suggest that you make use of our open source teamcity server, so that you can have a maintained mono version test run that's 'latest stable'? https://tc-oss.intelliplan.net/login.html |
|
I see - I'd be happy to upgrade it! I think there was some reason why were using old version (perhaps it was easier to install on Travis?) But maybe we just need to increment the number in: https://github.com/tpetricek/FSharp.Formatting/blob/master/.travis.yml |
|
Let's see what that gets us first. |
|
@haf If you send a PR adding the necessary config (if there is any) and a link to "how to" that I can follow, I'm more than happy to add TeamCity. |
|
@tpetricek start by adding an account and telling me the username, I'll make you project admin and then there's docs on how to set it up -- but in general it's 1) add VCS repo to github, 2) add command line build step where you call your build suite, 3) add git trigger on checkin, done. |
|
I think I'm signed up - as |
|
Ok, please fill out your details too =). |
|
I added my name & email - is there anything else? |
|
I set it up for you https://tc-oss.intelliplan.net/project.html?projectId=FSharp&tab=projectOverview |
|
So no, nothing else really... Using it :) Fixing builds and writing unit tests. This mono version has the problems discussed in the threads. |
|
I see something similar yet different when trying to generate API docs for a PCL library: At least, I think this is similar. If not, I'm happy to create a new case or, should someone be able to point me to docs, read up on what I'm missing / add docs once I or @t0yv0 discover what is amiss. |
|
@panesofglass It might or might not be related - but opening a separate issue is probably a good idea. Also, ping @dsyme because he might know how F# compiler (compiler service) behave when loading PCLs. |
|
Have you had the time to browse the error you get on the build server? @tpetricek |
|
Relevant fsharp/fsharp#317 |
|
@tpetricek do you know if F# Formatting works on mono with F# now? |
|
Is there a tl;dr?. What should I do? |
|
@tpetricek WIP SuaveIO/suave#225 and discussion: SuaveIO/suave#223 -- currently too swamped to try it, but if you checkout that branch, you should be able to run it right off the bat. |
|
I think we should either remove the command line tool (is anyone using that?) or add some tests for it. |
|
@matthid We want to use it; we are not using FAKE. |
|
Are there any docs for how to pass parameters to CommandTool besides reading source or the help output that doesn't tell you what's wrong? |
|
Ignore last comment; found docs had been improved a lot! https://tpetricek.github.io/FSharp.Formatting/commandline.html |
|
I think this issue is solved by now :) Thanks for fixing it! |
|
Hello people, I'm getting this error: But I'm not sure how to interpret it. How would you guys start debugging this? I'm working in this PR: |
Windows
OS X:
The text was updated successfully, but these errors were encountered: