Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for EL6 #994

Merged
merged 11 commits into from
Jul 23, 2020
Merged

Deprecate support for EL6 #994

merged 11 commits into from
Jul 23, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jul 13, 2020

RHEL / CentOS 6 support has been deprecated.
Account for st2mistral not being present on upgrades for some distributions.
Updates for MongoDB 4.0 being used on all distributions.

addressing st2docs - remove EL6 from StackStorm/community#39

@amanda11
Copy link
Contributor Author

EL6 removal from ewcdocs change that affects the build failure in stdocs, PR extremenetworks/ipfabric-docs#169

Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good so far, but could use a bit of polish.

@@ -136,8 +136,12 @@ This is the standard upgrade procedure:

sudo yum update st2 st2web st2chatops st2mistral

Omit st2mistral if it is not installed on your distribution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two comments could use a bit of expansion. Why would st2mistral not be installed on a server? It's required by StackStorm <= 3.2, so it should be there. For StackStorm >= 3.3, it won't be available. We should explain that here, possibly include a link to the changelog entry.

Copy link
Contributor Author

@amanda11 amanda11 Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blag it isn’t installed though on EL8 and neither for Bionic with ST 3.2 though. That was what I was trying to get across.
So I was thinking of it as part of a upgrade on el8 with what we have now.

I was trying to keep in the docs in step with where we were with the install. So was thinking of st2mistral not installed on EL8 etc. Rather than the changes for the end of ST 3.3 when st2mistral would be gone completely - as I think we've not taken that out yet from the install yet for EL7 etc.

docs/source/install/ewc.rst Outdated Show resolved Hide resolved
docs/source/install/puppet.rst Show resolved Hide resolved
@@ -28,9 +28,6 @@ be automatically added when you install |st2|.
| `RHEL 7 <https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux>`_ / | `bento/centos-7.4 <https://app.vagrantup.com/bento/boxes/centos-7.4>`_ | `Red Hat Enterprise Linux (RHEL) 7.2 (HVM) <https://aws.amazon.com/marketplace/pp/B019NS7T5I/ref=srh_res_product_title?ie=UTF8&sr=0-2&qid=1457037671547>`_ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 25 above, can you update for RHEL/CentOS 8.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated 8.2 centos. The only 8.2 AWS EC2 I could find is one from pro-computers. The AWS marketplace one is still the one above. Which do we want to link to?

@@ -113,6 +103,12 @@ below. Only execute the instructions for your distribution.
sudo yum erase st2 st2mistral st2chatops st2web st2python bwc-ui st2flow


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a note here for RHEL/CentOS 8.x?

I think it would be:
sudo yum erase st2 st2chatops st2web st2python bwc-ui st2flow

cc @armab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punkrokk Is that not covered by the note below on line 106- to omit st2mistral?
That was the wording we had on the 3.2 documentation to cover RH8/Ubuntu 18.

HOWEVER I'm not sure if it was deliberate but some of the changes in the 3.2 documentation aren't on the master branch - so the notes that were added for 3.2 for RH 8 about missing mistral etc, seemed to have got dropped from master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's probably covered by the note. I'm a fan of having a nice codeblock to copy and paste, which is why I made the suggestion and it seemed in line with the rest of the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punkrokk Let me know if the changes made are preferred. I changed the note that is in the current st2docs (https://docs.stackstorm.com/install/uninstall.html) with code blocks like you suggested.

I noticed a few other updates needed, e.g.
st2mistral and postgres not used on ubuntu 18.
st2python not used on rh 7/8
So a few more changes, and gone for the code blocks.

@punkrokk
Copy link
Member

StackStorm/st2#4972

@punkrokk
Copy link
Member

@amanda11 Please see the errors on the circle builds.

@amanda11
Copy link
Contributor Author

@amanda11 Please see the errors on the circle builds.

@punkrokk Fixed the st2docs error - the ewcdocs will fail until extremenetworks/ipfabric-docs#169 is merged as it is because ewcdocs refers to the RH 6 file. HOWEVER I'm not sure why the ipfabric-docs fails it's CI checks - seems to look for a branch that doesn't exist.

@arm4b arm4b added this to the 3.3.0 milestone Jul 16, 2020
@arm4b arm4b mentioned this pull request Jul 17, 2020
@arm4b
Copy link
Member

arm4b commented Jul 17, 2020

#996 should help with EWC Docs/dependency issue.
It's just a good time to stop building and updating them as EWC code was Open Sourced.

@amanda11
Copy link
Contributor Author

I think all review comments have been addressed, please feedback any extra changes required

@arm4b arm4b requested review from blag and punkrokk July 19, 2020 14:44
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@amanda11 Thanks for taking the ownership here!

Looks like @punkrokk and @blag feedback is addressed, so I'll merge the PR.

@arm4b arm4b merged commit 54b5397 into StackStorm:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants