-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate support for EL6 #994
Conversation
…arily being there on upgrade
EL6 removal from ewcdocs change that affects the build failure in stdocs, PR extremenetworks/ipfabric-docs#169 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good so far, but could use a bit of polish.
docs/source/install/upgrades.rst
Outdated
@@ -136,8 +136,12 @@ This is the standard upgrade procedure: | |||
|
|||
sudo yum update st2 st2web st2chatops st2mistral | |||
|
|||
Omit st2mistral if it is not installed on your distribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two comments could use a bit of expansion. Why would st2mistral not be installed on a server? It's required by StackStorm <= 3.2, so it should be there. For StackStorm >= 3.3, it won't be available. We should explain that here, possibly include a link to the changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blag it isn’t installed though on EL8 and neither for Bionic with ST 3.2 though. That was what I was trying to get across.
So I was thinking of it as part of a upgrade on el8 with what we have now.
I was trying to keep in the docs in step with where we were with the install. So was thinking of st2mistral not installed on EL8 etc. Rather than the changes for the end of ST 3.3 when st2mistral would be gone completely - as I think we've not taken that out yet from the install yet for EL7 etc.
@@ -28,9 +28,6 @@ be automatically added when you install |st2|. | |||
| `RHEL 7 <https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux>`_ / | `bento/centos-7.4 <https://app.vagrantup.com/bento/boxes/centos-7.4>`_ | `Red Hat Enterprise Linux (RHEL) 7.2 (HVM) <https://aws.amazon.com/marketplace/pp/B019NS7T5I/ref=srh_res_product_title?ie=UTF8&sr=0-2&qid=1457037671547>`_ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 25 above, can you update for RHEL/CentOS 8.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated 8.2 centos. The only 8.2 AWS EC2 I could find is one from pro-computers. The AWS marketplace one is still the one above. Which do we want to link to?
@@ -113,6 +103,12 @@ below. Only execute the instructions for your distribution. | |||
sudo yum erase st2 st2mistral st2chatops st2web st2python bwc-ui st2flow | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a note here for RHEL/CentOS 8.x?
I think it would be:
sudo yum erase st2 st2chatops st2web st2python bwc-ui st2flow
cc @armab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punkrokk Is that not covered by the note below on line 106- to omit st2mistral?
That was the wording we had on the 3.2 documentation to cover RH8/Ubuntu 18.
HOWEVER I'm not sure if it was deliberate but some of the changes in the 3.2 documentation aren't on the master branch - so the notes that were added for 3.2 for RH 8 about missing mistral etc, seemed to have got dropped from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's probably covered by the note. I'm a fan of having a nice codeblock
to copy and paste, which is why I made the suggestion and it seemed in line with the rest of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@punkrokk Let me know if the changes made are preferred. I changed the note that is in the current st2docs (https://docs.stackstorm.com/install/uninstall.html) with code blocks like you suggested.
I noticed a few other updates needed, e.g.
st2mistral and postgres not used on ubuntu 18.
st2python not used on rh 7/8
So a few more changes, and gone for the code blocks.
Co-authored-by: JP Bourget <[email protected]>
Co-authored-by: JP Bourget <[email protected]>
@amanda11 Please see the errors on the circle builds. |
@punkrokk Fixed the st2docs error - the ewcdocs will fail until extremenetworks/ipfabric-docs#169 is merged as it is because ewcdocs refers to the RH 6 file. HOWEVER I'm not sure why the ipfabric-docs fails it's CI checks - seems to look for a branch that doesn't exist. |
Co-authored-by: Eugen C. <[email protected]>
#996 should help with EWC Docs/dependency issue. |
I think all review comments have been addressed, please feedback any extra changes required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RHEL / CentOS 6 support has been deprecated.
Account for st2mistral not being present on upgrades for some distributions.
Updates for MongoDB 4.0 being used on all distributions.
addressing st2docs - remove EL6 from StackStorm/community#39