Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL7/U16 -> Mongo 4.0 Master Issue #4972

Closed
6 tasks done
punkrokk opened this issue Jun 24, 2020 · 11 comments
Closed
6 tasks done

EL7/U16 -> Mongo 4.0 Master Issue #4972

punkrokk opened this issue Jun 24, 2020 · 11 comments

Comments

@punkrokk
Copy link
Member

punkrokk commented Jun 24, 2020

Since Mongo 3.4 has been deprecated, we need to following Issues resolved in order to update/support Mongo 3.6 4.0 in ST2 v3.3.0

@punkrokk punkrokk added this to the 3.3.0 milestone Jun 24, 2020
@arm4b arm4b changed the title EL7/U16 -> Mongo3.6 Master Issue EL7/U16 -> Mongo 4.0 Master Issue Jun 29, 2020
@arm4b
Copy link
Member

arm4b commented Jun 29, 2020

RE st2docs, the following documentation page will need an update too:
https://github.com/StackStorm/st2docs/blob/master/docs/source/install/__mongodb_note.rst

@amanda11
Copy link
Contributor

@punkrokk I think I may have covered the st2docs change under this one: https://github.com/StackStorm/st2docs/pull/994/files (was amending a few other files when removing EL6 for functionality I knew we'd changed!)

@amanda11
Copy link
Contributor

@punkrokk In the st2 repo. In the circleci config file. When it runs the integration tests it points to the docker mongo:3.4. Does that need to be altered to point to mongo 4.0 as part of this issue?

@arm4b
Copy link
Member

arm4b commented Jul 16, 2020

For future reference, ideally not to mix several logically independent changes in one PR like EL6 deprecation and MongoDB 4.0 and EL8 link update and something else.
It's always better to create several dedicated PRs for each change for easy review and change/history reasons.

@punkrokk
Copy link
Member Author

@armab Good call, I think I lost focus on what the actual issue was !!!

@amanda11
Copy link
Contributor

For future reference, ideally not to mix several logically independent changes in one PR like EL6 deprecation and MongoDB 4.0 and EL8 link update and something else.
It's always better to create several dedicated PRs for each change for easy review and change/history reasons.

Point noted. Got carried away when noticing errors in docs. Will do separate PRs next time to make it easier to review/track.

@amanda11
Copy link
Contributor

amanda11 commented Aug 7, 2020

@punkrokk I noticed that in st2 repo the travis and circleci still refer to mongo 3.4 for their runs on python 2.7, not mongo 4.0. Do we need another checkbox to resolve those?

@punkrokk
Copy link
Member Author

punkrokk commented Aug 7, 2020 via email

@arm4b
Copy link
Member

arm4b commented Aug 8, 2020

Sure, good spotting!

@amanda11
Copy link
Contributor

amanda11 commented Sep 4, 2020

@armab @punkrokk I checked in a PR that changed the ST2 CirlceCI and Travis to use mongo 4.0, is there any other CI/CD places that need changing (it was the one that I had noticed was missing)? Or is that mongo 4.0 finished now?

@arm4b
Copy link
Member

arm4b commented Sep 4, 2020

I’m not aware of any other places with mongo 3.4
@amanda11 Thanks for tracking this down! Sure, feel free to close the issue.

@amanda11 amanda11 closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants