[WIP] Experimental and opt-in Python 3 support for Python runner actions #4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an entry for the st2-track-result command line utility into the setup script.
Additional changes for v2.7.0
Update release date for the v2.7.0 release (v2.7)
for packs. This way we ensure version of pip which is on the system is used instead of latest stable version of pip and other packages being download from PyPi on virtualenv creation.
a virtualenv for tests. This way we ensure consistent build environment.
This way we ensure all the submodules are checked out.
and allow it to be used outside the nose tests context.
This way it fixes regression introduced in 2.7.0 and sensors which rely on subprocess.poll() (select.poll()) still work in the same manner as they did before v2.7.0.
poll() which was removed.
This reverts commit c72bf48.
explicitly install pyyaml dependency into it instead of re-using one from st2 virtual environment site-packages since pyyaml ships different code for Python 2 and Python 3.
Python 3 is used for a pack virtual environment.
This way the code is more readable and easier to unit test.
executing a particular pack actions.
|
EDIT - Closing, I some how merged that branch, accidentally based it on top of v2.6 and not master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds experimental and opt-in support for using Python 3 for pack actions.
It continues work from other PRs - #3922, #4016, #4075.
Our code changes in the past were a bit too optimistic and it turned out a lot more work is still needed to get that feature working.
The scope and target audience for this feature didn't change - it's still intended for advanced users and it's opt in - user needs to pass in
--python3flag tost2 pack install <pack name>CLI command and Python 3 binary will be used when creating virtual environment for that pack and for all the subsequent pack action executions.As mentioned before, this feature is mostly meant as an experimental stop gap for advanced users until the whole platform supports Python 3 (aka StackStorm itself can run on Python 3).
We don't have any specific ETA for Python 3 support for the whole platform, but we are slowly and incrementally working towards it - every time I touch some code, I try to also make it work under Python 3 and and make sure tests for that code also run under Python 3 on Travis.
Included Changes
TBW
Example Usage
1. Not using Python 3 (default behavior)
2. Opting in and using Python 3 for a particular park
TODO