Remove changelog entry for --python3 "st2 pack install" CLI flag #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2018
|
Corresponding documentation change removal - StackStorm/st2docs#718, StackStorm/st2docs#719. |
enykeev
approved these changes
Apr 10, 2018
|
@Kami :-( what were the issues? |
|
@tonybaloney Sadly I didn't really have time to dig in much, but it looks like yaml package and some StackStorm related imports (yaml stuff might be related to absolute imports, but didn't have time to dig in). Having said that, I will add some (failing) tests for that functionality post v2.7.0 and we can start from there :) |
This was referenced May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the release testing, we encountered some issues with this feature (thanks to @warrenvw and @m4dcoder, I also confirmed some of that issues on Ubuntu 16.06 which ships with Python 3 by default).
There are still some scenarios related to StackStorm and 3rd party library imports which don't work and cause exceptions so that feature doesn't work as expected.
For now the best thing to do is to simple remove any mention of this feature. I removed the changelog entry and
--python3flag, but I left action parameter there since it's an implementation detail and will make it easier for us to test it and work on it in the future (but it doesn't in any way affect our users since it's disabled by default).Sadly I didn't have time to dig in and we need to get the release out. Hopefully we will have time to dig in and get it fixed and fully working in time for v2.8.0.
/cc @tonybaloney ^Just a heads up