Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove st2mistral packaging and builds #656

Merged
merged 6 commits into from
Aug 10, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jul 31, 2020

Removal of postgres and mistral from packages, docker and vagrant

Scripted-installer changes are not included.

Addresses st2-packages of StackStorm/st2#4762
Closes #121, closes #487, closes #474, closes #455, closes #421

@amanda11 amanda11 marked this pull request as draft July 31, 2020 14:15
@amanda11
Copy link
Contributor Author

Draft still - as need to do some manual testing, but wanted circleci feedback.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Similar to #654, would be easier to split such a big change into 2 separated PRs:

  1. remove mistral from the scripted installer, CircleCI, Readme update, see Remove EL6 from the scripted installer, stop CircleCI builds #654
  2. deeper-level packaging/makefile/etc changes (this PR)

It's easier to start with 1 first. This will be more convenient to review, track and switch-context.

@arm4b arm4b changed the title Initial mistral removal [WIP] Remove st2mistral packaging and builds [WIP] Aug 3, 2020
@arm4b
Copy link
Member

arm4b commented Aug 3, 2020

Thanks for splitting those PRs!

@amanda11 amanda11 changed the title Remove st2mistral packaging and builds [WIP] Remove st2mistral packaging and builds Aug 3, 2020
@amanda11 amanda11 marked this pull request as ready for review August 3, 2020 16:21
RUNNERS := $(shell ls -I mistral* ../contrib/runners)
else ifeq ($(EL_VERSION),8)
# Don't include Mistral runner
# TODO: Go back to all runners when mistral removed from st2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand we'll need another PR in st2-packages, once the mistral removal happens in the st2 repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it's a bit chicken and egg. It will still work when we take out mistral from contrib/runners in ST2 - but we should tidy up afterwards.
But this code can be used before and after the ST2 changes.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment