Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EL6 from the scripted installer, stop CircleCI builds #654

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

eorochena
Copy link
Contributor

@eorochena eorochena commented Jul 1, 2020

Removed EL6 from the scripted installer and stop EL6 builds in CIrcleCI, following StackStorm/community#39

This PR doesn't cover rpm adjustments and st2python removal related to EL6 packaging.

@eorochena eorochena force-pushed the master branch 2 times, most recently from 4a04379 to 4ba173e Compare July 1, 2020 03:50
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution and help removing EL6!

As I understand in this PR we're covering the following sub-tasks from the StackStorm/community#39

  • update scripted installer to remove EL6 support
  • stop the EL6 build in CircleCI

I updated the original PR description and also provided more feedback in the comments below.
Please also adjust the list of OS supported platforms here:

if [[ "$RHMAJVER" != '6' && "$RHMAJVER" != '7' && "$RHMAJVER" != '8' ]]; then
echo "Unsupported distro version $RHMAJVER! Aborting!"
exit 2
fi

.circle/packagecloud.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rake/build/setup.rake Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@arm4b arm4b added this to the 3.3.0 milestone Jul 1, 2020
@arm4b arm4b changed the title removed centos6 and el6 references Remove EL6 from the scripted installer, stop CircleCI builds Jul 1, 2020
@eorochena
Copy link
Contributor Author

@armab I have implemented or the necessary changes to the PR also all CI checks have passed,.

Thanks for the suggestions.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@arm4b arm4b merged commit 01b90f6 into StackStorm:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants