-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EL6 from the scripted installer, stop CircleCI builds #654
Conversation
4a04379
to
4ba173e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution and help removing EL6
!
As I understand in this PR we're covering the following sub-tasks from the StackStorm/community#39
- update scripted installer to remove EL6 support
- stop the EL6 build in CircleCI
I updated the original PR description and also provided more feedback in the comments below.
Please also adjust the list of OS supported platforms here:
st2-packages/scripts/st2_bootstrap.sh
Lines 155 to 158 in 5d92c25
if [[ "$RHMAJVER" != '6' && "$RHMAJVER" != '7' && "$RHMAJVER" != '8' ]]; then | |
echo "Unsupported distro version $RHMAJVER! Aborting!" | |
exit 2 | |
fi |
@armab I have implemented or the necessary changes to the PR also all CI checks have passed,. Thanks for the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
Removed EL6 from the scripted installer and stop EL6 builds in CIrcleCI, following StackStorm/community#39
This PR doesn't cover
rpm
adjustments andst2python
removal related to EL6 packaging.