Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): Update backend server health check endpoint #8351

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

aarushik93
Copy link
Contributor

Background

Removed docs endpoint. Should now use health endpoint

Changes πŸ—οΈ

Changed /docs > /health in values.dev and values.prod for server

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested review from a team as code owners October 16, 2024 15:00
@aarushik93 aarushik93 requested review from ntindle and Swiftyos and removed request for a team October 16, 2024 15:00
@github-actions github-actions bot added documentation Improvements or additions to documentation platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Oct 16, 2024
@aarushik93 aarushik93 enabled auto-merge (squash) October 16, 2024 15:00
@aarushik93 aarushik93 changed the base branch from master to dev October 16, 2024 15:00
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 πŸ”΅πŸ”΅πŸ”΅πŸ”΅βšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Potential Performance Issue
The removal of asyncio and the change to a synchronous execution model may impact performance, especially for I/O-bound operations. This should be carefully evaluated to ensure it doesn't introduce bottlenecks.

Error Handling
The error handling in the execute_node function has been simplified. Ensure that this doesn't lead to loss of important error information or improper error propagation.

New Component
A new DatabaseManager class has been introduced. This centralization of database operations should be reviewed for completeness and potential impact on existing database interactions throughout the application.

Security Concern
The new delete_credentials function includes token revocation. Ensure that this process is secure and handles all possible error cases, especially for different provider implementations.

Copy link

netlify bot commented Oct 16, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 1ebfff9
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/670fd4f5b5f88600085ec6ef

@github-actions github-actions bot added size/s and removed documentation Improvements or additions to documentation platform/frontend AutoGPT Platform - Front end size/xl labels Oct 16, 2024
@aarushik93 aarushik93 merged commit 405dd16 into dev Oct 16, 2024
6 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/update-k8s-health-check branch October 16, 2024 15:02
aarushik93 added a commit that referenced this pull request Oct 16, 2024
* feat(platform): List and revoke credentials in user profile (#8207)

Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API: of the providers we currently have, Google and GitHub support it; Notion doesn't.

- Add credentials list and `Delete` button in `/profile`
- Add `revoke_tokens` abstract method to `BaseOAuthHandler` and implement it in each provider
- Revoke OAuth tokens for providers on `DELETE` `/{provider}/credentials/{cred_id}`, and return whether tokens could be revoked
   - Update `autogpt-server-api/baseClient.ts:deleteCredentials` with `CredentialsDeleteResponse` return type

Bonus:
- Update `autogpt-server-api/baseClient.ts:_request` to properly handle empty server responses

* fix(backend): Lower the number of node workers to save DB connections (#8331)

Change [graph]Γ—[node] worker limit from 10Γ—5 to 10Γ—3

---------

Co-authored-by: Reinier van der Leer <[email protected]>

* fix(ci,platform): Add dev branch trigger to all ci (#8339)

* update ci for dev

* update classic

* remove duplicate dev

* fix(frontend): Fix styling inconsistencies in input elements (#8337)

- Apply consistent border styling to `Input`, `Select`, and `Textarea`
   - Remove `rounded-xl` from node input elements

- Add `whitespace-nowrap` to `CustomNode` header category tags

---------

Co-authored-by: Zamil Majdy <[email protected]>

* feat(builder): Use configmap for builder (#8343)

use configmap in builder

* fix(platform,infra): Checkin non secret values  (#8344)

checkin non secrets

* security(platform): Add sealed secrets (#8342)

* add sealed secrets

* add encrypted secrets

* remove extra space

* Tf public media buckets (#8324)

* fix(infra): Fix sealed secret names  (#8350)

* fix sealed secret names

* fix names and add annotation

* feat(backend): Introduce executors shared DB connection (#8340)

* update health checkendpoint

---------

Co-authored-by: Krzysztof Czerwinski <[email protected]>
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Co-authored-by: Swifty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants