-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): List and revoke credentials in user profile #8207
Merged
Pwuts
merged 19 commits into
dev
from
kpczerwinski/open-1713-allow-users-to-revoke-oauth-permissions
Oct 14, 2024
Merged
feat(platform): List and revoke credentials in user profile #8207
Pwuts
merged 19 commits into
dev
from
kpczerwinski/open-1713-allow-users-to-revoke-oauth-permissions
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform/frontend
AutoGPT Platform - Front end
platform/backend
AutoGPT Platform - Back end
size/l
labels
Sep 27, 2024
✅ Deploy Preview for auto-gpt-docs canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
…ke-oauth-permissions
kcze
requested review from
Torantulino,
aarushik93,
Pwuts and
majdyz
and removed request for
a team,
Torantulino and
aarushik93
September 30, 2024 18:32
Pwuts
reviewed
Oct 1, 2024
autogpt_platform/backend/backend/server/routers/integrations.py
Outdated
Show resolved
Hide resolved
Pwuts
reviewed
Oct 1, 2024
autogpt_platform/frontend/src/lib/autogpt-server-api/baseClient.ts
Outdated
Show resolved
Hide resolved
Pwuts
reviewed
Oct 1, 2024
Pwuts
reviewed
Oct 1, 2024
Pwuts
reviewed
Oct 1, 2024
github-actions
bot
added
the
conflicts
Automatically applied to PRs with merge conflicts
label
Oct 3, 2024
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
…ke-oauth-permissions
github-actions
bot
added
documentation
Improvements or additions to documentation
and removed
conflicts
Automatically applied to PRs with merge conflicts
labels
Oct 10, 2024
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Pwuts
force-pushed
the
kpczerwinski/open-1713-allow-users-to-revoke-oauth-permissions
branch
from
October 11, 2024 19:55
1ee9b07
to
ac3eec2
Compare
…ke-oauth-permissions
- set content maximum width - add icons to buttons - fix alignment of log out button - fix spacing of Actions column in credentials table - fix heading size
Pwuts
previously approved these changes
Oct 14, 2024
Pwuts
approved these changes
Oct 14, 2024
Pwuts
deleted the
kpczerwinski/open-1713-allow-users-to-revoke-oauth-permissions
branch
October 14, 2024 15:50
aarushik93
added a commit
that referenced
this pull request
Oct 16, 2024
* feat(platform): List and revoke credentials in user profile (#8207) Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API: of the providers we currently have, Google and GitHub support it; Notion doesn't. - Add credentials list and `Delete` button in `/profile` - Add `revoke_tokens` abstract method to `BaseOAuthHandler` and implement it in each provider - Revoke OAuth tokens for providers on `DELETE` `/{provider}/credentials/{cred_id}`, and return whether tokens could be revoked - Update `autogpt-server-api/baseClient.ts:deleteCredentials` with `CredentialsDeleteResponse` return type Bonus: - Update `autogpt-server-api/baseClient.ts:_request` to properly handle empty server responses * fix(backend): Lower the number of node workers to save DB connections (#8331) Change [graph]×[node] worker limit from 10×5 to 10×3 --------- Co-authored-by: Reinier van der Leer <[email protected]> * fix(ci,platform): Add dev branch trigger to all ci (#8339) * update ci for dev * update classic * remove duplicate dev * fix(frontend): Fix styling inconsistencies in input elements (#8337) - Apply consistent border styling to `Input`, `Select`, and `Textarea` - Remove `rounded-xl` from node input elements - Add `whitespace-nowrap` to `CustomNode` header category tags --------- Co-authored-by: Zamil Majdy <[email protected]> * feat(builder): Use configmap for builder (#8343) use configmap in builder * fix(platform,infra): Checkin non secret values (#8344) checkin non secrets * security(platform): Add sealed secrets (#8342) * add sealed secrets * add encrypted secrets * remove extra space * Tf public media buckets (#8324) * fix(infra): Fix sealed secret names (#8350) * fix sealed secret names * fix names and add annotation * feat(backend): Introduce executors shared DB connection (#8340) * update health checkendpoint --------- Co-authored-by: Krzysztof Czerwinski <[email protected]> Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Zamil Majdy <[email protected]> Co-authored-by: Swifty <[email protected]>
aarushik93
added a commit
that referenced
this pull request
Oct 16, 2024
* feat(platform): List and revoke credentials in user profile (#8207) Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API: of the providers we currently have, Google and GitHub support it; Notion doesn't. - Add credentials list and `Delete` button in `/profile` - Add `revoke_tokens` abstract method to `BaseOAuthHandler` and implement it in each provider - Revoke OAuth tokens for providers on `DELETE` `/{provider}/credentials/{cred_id}`, and return whether tokens could be revoked - Update `autogpt-server-api/baseClient.ts:deleteCredentials` with `CredentialsDeleteResponse` return type Bonus: - Update `autogpt-server-api/baseClient.ts:_request` to properly handle empty server responses * fix(backend): Lower the number of node workers to save DB connections (#8331) Change [graph]×[node] worker limit from 10×5 to 10×3 --------- Co-authored-by: Reinier van der Leer <[email protected]> * fix(ci,platform): Add dev branch trigger to all ci (#8339) * update ci for dev * update classic * remove duplicate dev * fix(frontend): Fix styling inconsistencies in input elements (#8337) - Apply consistent border styling to `Input`, `Select`, and `Textarea` - Remove `rounded-xl` from node input elements - Add `whitespace-nowrap` to `CustomNode` header category tags --------- Co-authored-by: Zamil Majdy <[email protected]> * feat(builder): Use configmap for builder (#8343) use configmap in builder * fix(platform,infra): Checkin non secret values (#8344) checkin non secrets * security(platform): Add sealed secrets (#8342) * add sealed secrets * add encrypted secrets * remove extra space * Tf public media buckets (#8324) * fix(infra): Fix sealed secret names (#8350) * fix sealed secret names * fix names and add annotation * feat(backend): Introduce executors shared DB connection (#8340) * update health checkendpoint --------- Co-authored-by: Krzysztof Czerwinski <[email protected]> Co-authored-by: Reinier van der Leer <[email protected]> Co-authored-by: Zamil Majdy <[email protected]> Co-authored-by: Swifty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
platform/backend
AutoGPT Platform - Back end
platform/frontend
AutoGPT Platform - Front end
size/l
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Changes 🏗️
Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API; in this case, only Google and GitHub support it, Notion doesn't.
Delete
button in/profile
revoke_tokens
abstract method toBaseOAuthHandler
and implement it in each providerDELETE
/{provider}/credentials/{cred_id}
, and return whether tokens could be revokedautogpt-server-api/baseClient.ts:deleteCredentials
withCredentialsDeleteResponse
return typeautogpt-server-api/baseClient.ts:_request
to properly handle empty server responsesTesting 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/