Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Update block UI #8260

Merged
merged 38 commits into from
Oct 12, 2024
Merged

feat(frontend): Update block UI #8260

merged 38 commits into from
Oct 12, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Oct 3, 2024

Background

This is the revival of #8190.
With the input-field bug fixed

Changes πŸ—οΈ

Update block UI based on the agreed design.

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@majdyz majdyz requested review from Swiftyos and Bentlybro October 3, 2024 22:34
@majdyz majdyz requested a review from a team as a code owner October 3, 2024 22:34
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/xl labels Oct 3, 2024
Copy link

qodo-merge-pro bot commented Oct 3, 2024

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 πŸ”΅πŸ”΅πŸ”΅βšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Code Complexity
The CustomNode component has become quite complex with multiple nested conditions and components. Consider breaking it down into smaller, more manageable sub-components for better maintainability.

Performance Concern
The component is re-creating the categories array on every render. Consider memoizing this value to improve performance.

Potential Bug
The InputRef function is using a closure to set the input value. This might lead to stale values if the component re-renders. Consider using useRef or controlled inputs instead.

Copy link

netlify bot commented Oct 3, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 91c11df
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/670a4016613d830008aeccb2

@majdyz majdyz force-pushed the zamilmajdy/block-ui-update branch from 2c70698 to c39a0b1 Compare October 4, 2024 13:41
@Swiftyos
Copy link
Contributor

Swiftyos commented Oct 7, 2024

Checked API Key is not leaked
Screenshot 2024-10-07 at 10 53 24

{
  "id": "ed5d851c-9343-4b9f-bef6-276233301102",
  "version": 1,
  "is_active": true,
  "is_template": false,
  "name": "apitest",
  "description": "Agent Description",
  "executions": null,
  "nodes": [
    {
      "id": "3969861a-9af3-477c-8c05-08f9bff9675e",
      "block_id": "1f292d4a-41a4-4977-9684-7c8d560b9f91",
      "input_default": {},
      "metadata": {
        "position": {
          "x": 608,
          "y": 132.5
        }
      }
    }
  ],
  "links": [],
  "subgraphs": {}
}

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 10, 2024
Copy link
Contributor

Conflicts have been resolved! πŸŽ‰ A maintainer will review the pull request shortly.

ntindle
ntindle previously approved these changes Oct 10, 2024
@ntindle
Copy link
Member

ntindle commented Oct 10, 2024

you need to commit your lock file updates btw

@Pwuts Pwuts changed the title feat(platform): Update block UI feat(frontend): Update block UI Oct 10, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 11, 2024
Copy link
Contributor

Conflicts have been resolved! πŸŽ‰ A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 11, 2024
@majdyz majdyz force-pushed the zamilmajdy/block-ui-update branch from d5e5b43 to ed42a52 Compare October 11, 2024 16:22
Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and its all working

@Bentlybro Bentlybro merged commit 8502928 into master Oct 12, 2024
14 checks passed
@Bentlybro Bentlybro deleted the zamilmajdy/block-ui-update branch October 12, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/xl
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

5 participants