-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak(frontend): Update Blocks UI #8190
Conversation
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…yos/secrt-900-update-block-ui
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
I got here through a notification and only reviewed the changes from one commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the gist of these changes, but it needs significant polishing:
- I'm not sure this changed border radius is really an improvement...
- .. and it's not consistent ..
- .. across inputs. This kind of aesthetic adjustments should be made as part of a complete design, across the board, and in the base shad/cn components themselves. In this case, I suggest reverting these changes. Functionality and layout is much more important than the exact aesthetics at our current stage anyway.
- Zero margin
- Uneven vertical alignment
- Both vertical and horizontal alignment is off here: vertical misalignment between the handles and the input boxes, and horizontal misalignment between the "+ Add Item" button and the rest. That button should probably be full-width.
- Horizontal separator does not connect to outer box on the left, while it does on the right
@Pwuts did you test this or is this coming from the initial screenshots? Can you checkout the branch, test it, and see if those comments are still valid? For 7 it was intentional. Discussion on the design can be done separately |
… swiftyos/secrt-900-update-block-ui
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything seems to be working well 😄
Background
The current agent flows are engineering prototypes. For the beta we are doing a refresh with rapid fire design tweaks by a pro.
This PR aims to implement our designers work on the blocks ui
Changes 🏗️
Screen.Recording.2024-09-27.at.16.22.27.mov
Screen.Recording.2024-09-27.at.16.50.33.mov
Testing 🔍
Note
Only for the new autogpt platform, currently in autogpt_platform/