Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(frontend): Update Blocks UI #8190

Merged
merged 62 commits into from
Oct 3, 2024
Merged

Conversation

Swiftyos
Copy link
Contributor

@Swiftyos Swiftyos commented Sep 26, 2024

Background

The current agent flows are engineering prototypes. For the beta we are doing a refresh with rapid fire design tweaks by a pro.

This PR aims to implement our designers work on the blocks ui

Changes 🏗️

  • Update Block UI
  • Added Context Menu for blocks
  • Updated Block Connecting line to terminate at handles
  • Update Tutorial and Tally Buttons
  • Added pointer indicator in Block Control Panel
Screen.Recording.2024-09-27.at.16.22.27.mov
Screen.Recording.2024-09-27.at.16.50.33.mov
Screenshot 2024-09-27 at 16 50 19

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end size/l labels Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit ac6ec23
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66fdfbb62cb6e600088e1920
😎 Deploy Preview https://deploy-preview-8190--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Sep 27, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Pwuts
Pwuts previously approved these changes Oct 2, 2024
@Pwuts Pwuts dismissed their stale review October 2, 2024 14:17

I got here through a notification and only reviewed the changes from one commit

Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the gist of these changes, but it needs significant polishing:
image

  1. I'm not sure this changed border radius is really an improvement...
  2. .. and it's not consistent ..
  3. .. across inputs. This kind of aesthetic adjustments should be made as part of a complete design, across the board, and in the base shad/cn components themselves. In this case, I suggest reverting these changes. Functionality and layout is much more important than the exact aesthetics at our current stage anyway.
  4. Zero margin
  5. Uneven vertical alignment
  6. Both vertical and horizontal alignment is off here: vertical misalignment between the handles and the input boxes, and horizontal misalignment between the "+ Add Item" button and the rest. That button should probably be full-width.
  7. Horizontal separator does not connect to outer box on the left, while it does on the right

@majdyz
Copy link
Contributor

majdyz commented Oct 2, 2024

@Pwuts did you test this or is this coming from the initial screenshots?
I've been aligning this current PR from its initial state with the current design.

Can you checkout the branch, test it, and see if those comments are still valid?

For 7 it was intentional. Discussion on the design can be done separately

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@majdyz majdyz requested review from Pwuts, majdyz and Bentlybro October 3, 2024 02:10
@Swiftyos Swiftyos disabled auto-merge October 3, 2024 08:51
@Swiftyos Swiftyos enabled auto-merge (squash) October 3, 2024 08:51
Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to be working well 😄

@Swiftyos Swiftyos disabled auto-merge October 3, 2024 10:16
@Swiftyos Swiftyos merged commit 1114b42 into master Oct 3, 2024
14 checks passed
@Swiftyos Swiftyos deleted the swiftyos/secrt-900-update-block-ui branch October 3, 2024 10:16
Swiftyos added a commit that referenced this pull request Oct 3, 2024
Swiftyos added a commit that referenced this pull request Oct 3, 2024
majdyz added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 4 size/xl
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants