-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Config type hint problems caused by #4803 #4840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4840 +/- ##
==========================================
- Coverage 70.83% 70.62% -0.22%
==========================================
Files 69 69
Lines 3360 3387 +27
Branches 546 554 +8
==========================================
+ Hits 2380 2392 +12
- Misses 802 811 +9
- Partials 178 184 +6
☔ View full report in Codecov by Sentry. |
lc0rp
approved these changes
Jun 30, 2023
BasilBarnabyCa
added a commit
to BasilBarnabyCa/Auto-GPT
that referenced
this pull request
Jun 30, 2023
Fix Config type hint problems caused by Significant-Gravitas#4803 (Significant-Gravitas#4840)
dayofthedave
pushed a commit
to dayofthedave/Auto-GPT
that referenced
this pull request
Jul 17, 2023
…gnificant-Gravitas#4840) Co-authored-by: Luke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Changes
Config
toConfigBuilder
ConfigSettings
toConfig
I chose to rename the definitions instead of fixing all usages, because that would be a lot more work:
Config
is used in most of the files in the repo.Documentation
x
Test Plan
CI
PR Quality Checklist