Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Config type hint problems caused by #4803 #4840

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jun 29, 2023

Background

Changes

  • Rename Config to ConfigBuilder
  • Rename ConfigSettings to Config
  • Fix adjacent type hints here and there

I chose to rename the definitions instead of fixing all usages, because that would be a lot more work: Config is used in most of the files in the repo.

Documentation

x

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 62ef4c8
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/649eb842051b1b000869c8c7

@Pwuts Pwuts self-assigned this Jun 29, 2023
@Pwuts Pwuts added bug Something isn't working re-arch labels Jun 29, 2023
@Pwuts Pwuts added this to the v0.4.4 Release milestone Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 78.66% and project coverage change: -0.22 ⚠️

Comparison is base (975094f) 70.83% compared to head (62ef4c8) 70.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4840      +/-   ##
==========================================
- Coverage   70.83%   70.62%   -0.22%     
==========================================
  Files          69       69              
  Lines        3360     3387      +27     
  Branches      546      554       +8     
==========================================
+ Hits         2380     2392      +12     
- Misses        802      811       +9     
- Partials      178      184       +6     
Impacted Files Coverage Δ
autogpt/logs.py 73.65% <50.00%> (-0.90%) ⬇️
autogpt/plugins/__init__.py 72.61% <50.00%> (-0.94%) ⬇️
autogpt/speech/base.py 54.16% <50.00%> (-2.98%) ⬇️
autogpt/speech/eleven_labs.py 29.72% <60.00%> (+0.31%) ⬆️
autogpt/main.py 22.07% <66.66%> (+1.02%) ⬆️
autogpt/plugins/plugins_config.py 76.36% <66.66%> (-2.49%) ⬇️
autogpt/workspace/workspace.py 92.85% <75.00%> (-1.59%) ⬇️
autogpt/speech/say.py 37.50% <77.77%> (-0.44%) ⬇️
autogpt/config/config.py 73.46% <92.59%> (-0.48%) ⬇️
autogpt/agent/agent.py 59.18% <100.00%> (+0.27%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lc0rp lc0rp merged commit 5070cc3 into master Jun 30, 2023
@lc0rp lc0rp deleted the fix/config-type-hints branch June 30, 2023 12:15
BasilBarnabyCa added a commit to BasilBarnabyCa/Auto-GPT that referenced this pull request Jun 30, 2023
dayofthedave pushed a commit to dayofthedave/Auto-GPT that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working re-arch size/l
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants