Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Configuration of rearch #4803

Merged

Conversation

waynehamadi
Copy link
Contributor

Background

We can start integrating some of the elements of the rearch in master. Thanks @collijk !

Changes

  • Add the new Configuration class along with other methods and classes coming straight from the rearch
  • integrated the config with these new objects.
  • clearly separate default values from the rest of the logic.
  • clearly separate what comes from the env from the rest of the logic (so that we can build a config without an env file.
  • Code cleanup

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 068dcfd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/649a089e6698ca000844b985

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 75.41% and project coverage change: +0.14 🎉

Comparison is base (b157054) 70.78% compared to head (fcff3cb) 70.92%.

❗ Current head fcff3cb differs from pull request most recent head 068dcfd. Consider uploading reports for the commit 068dcfd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4803      +/-   ##
==========================================
+ Coverage   70.78%   70.92%   +0.14%     
==========================================
  Files          68       69       +1     
  Lines        3327     3347      +20     
  Branches      532      542      +10     
==========================================
+ Hits         2355     2374      +19     
  Misses        795      795              
- Partials      177      178       +1     
Impacted Files Coverage Δ
autogpt/main.py 23.52% <33.33%> (ø)
autogpt/core/configuration/schema.py 64.58% <64.58%> (ø)
autogpt/configurator.py 30.37% <69.23%> (ø)
autogpt/config/config.py 73.94% <81.57%> (+5.30%) ⬆️
autogpt/plugins/__init__.py 73.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi force-pushed the use-config-of-rearch branch from fcff3cb to 19e52a3 Compare June 26, 2023 21:02
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

autogpt/core/configuration/schema.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
autogpt/core/configuration/schema.py Outdated Show resolved Hide resolved
autogpt/core/configuration/schema.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@waynehamadi waynehamadi force-pushed the use-config-of-rearch branch from 97b34c7 to 068dcfd Compare June 26, 2023 21:52
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

@waynehamadi waynehamadi merged commit 9f353f4 into Significant-Gravitas:master Jun 27, 2023
@Pwuts
Copy link
Member

Pwuts commented Jun 29, 2023

This has caused type-checking errors everywhere:

main.py:
image

agent.py:
image

image

This pretty much breaks my development workflow because it floods the static code analysis with errors, drowning out any actual problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants