Migrate google search to use DDGS.text function #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uckgo search - backward compatiable
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
kinance
changed the title
1 task
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4383 +/- ##
=======================================
Coverage 64.90% 64.91%
=======================================
Files 75 75
Lines 3542 3543 +1
Branches 520 520
=======================================
+ Hits 2299 2300 +1
Misses 1071 1071
Partials 172 172
☔ View full report in Codecov by Sentry. |
…earch-deprecated-max-results
lc0rp
approved these changes
May 24, 2023
k-boikov
changed the title
kuwork
added a commit
to kuwork/Auto-GPT
that referenced
this pull request
May 24, 2023
* master: Migrate google search to use DDGS.text function (Significant-Gravitas#4383) empty commit to see cassette status (Significant-Gravitas#4382) Fix the version of duckduckgo-search to avoid empty result issue (Significant-Gravitas#4368) Update get_hyperlinks description (Significant-Gravitas#4122) CI: set base repo before `gh pr checkout` (Significant-Gravitas#4363) Cassettes should be added in the same pull request, without extra pull request (Significant-Gravitas#4355) Improve Azure setup wording in docs (Significant-Gravitas#4325) Pass command line args as list (Significant-Gravitas#1486)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The new duckduckgo_search version deprecated the ddg function and max_result parameters. Users are seeing the following warning messages when auto-gpt executes google command.
*\AppData\Local\Programs\Python\Python310\lib\site-packages\duckduckgo_search\compat.py:20: UserWarning: ddg is deprecated. Use DDGS().text() generator warnings.warn("ddg is deprecated. Use DDGS().text() generator")
UserWarning: parameter max_results is deprecated, use DDGS().text() warnings.warn("parameter max_results is deprecated, use DDGS().text()")
This fixes #4376
Changes
Migrate the search func to use the new function and use islice to limit the iterators up to max_results. Itertools.islice handles the iterators in an efficient way. Itertools is a module in python.
Documentation
Test Plan
Updated the google search's integration test
PR Quality Checklist
black .andisort .against my code to ensure it passes our linter.