Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Azure setup wording in docs #4325

Merged
merged 4 commits into from
May 22, 2023
Merged

Improve Azure setup wording in docs #4325

merged 4 commits into from
May 22, 2023

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented May 20, 2023

Background

Azure docs are unclear

Changes

Adds a note about the deployment name not being the deployment ID

Documentation

Only Docs changes

Test Plan

Setup Azure

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run black . and isort . against my code to ensure it passes our linter.

@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 9:45pm

@vercel vercel bot temporarily deployed to Preview May 20, 2023 22:47 Inactive
@ntindle ntindle requested a review from richbeales May 20, 2023 22:47
@ntindle ntindle added this to the v0.3.2 Release milestone May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e24d31) 64.76% compared to head (ea03aaa) 64.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4325   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          75       75           
  Lines        3542     3542           
  Branches      520      520           
=======================================
  Hits         2294     2294           
  Misses       1078     1078           
  Partials      170      170           
Impacted Files Coverage Δ
autogpt/commands/execute_code.py 58.62% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/setup.md Outdated Show resolved Hide resolved
@ntindle ntindle added the documentation Improvements or additions to documentation label May 21, 2023
@vercel vercel bot temporarily deployed to Preview May 22, 2023 21:45 Inactive
@k-boikov k-boikov changed the title Update setup.md Improve Azure setup wording in docs May 22, 2023
@k-boikov k-boikov merged commit cc709bb into master May 22, 2023
@k-boikov k-boikov deleted the azure-docs-update branch May 22, 2023 21:51
kuwork added a commit to kuwork/Auto-GPT that referenced this pull request May 24, 2023
* master:
  Migrate google search to use DDGS.text function (Significant-Gravitas#4383)
  empty commit to see cassette status (Significant-Gravitas#4382)
  Fix the version of duckduckgo-search to avoid empty result issue (Significant-Gravitas#4368)
  Update get_hyperlinks description (Significant-Gravitas#4122)
  CI: set base repo before `gh pr checkout` (Significant-Gravitas#4363)
  Cassettes should be added in the same pull request, without extra pull request (Significant-Gravitas#4355)
  Improve Azure setup wording in docs (Significant-Gravitas#4325)
  Pass command line args as list (Significant-Gravitas#1486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/s
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants