feat(Accordion): ability to open multiple items #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing multiple open panels at once, need help with transforming activeIndex prop to an array.
Current coverage is 100% (diff: 100%)@@ master #988 diff @@
======================================
Files 140 137 -3
Lines 2304 2287 -17
Methods 0 0
Messages 0 0
Branches 0 0
======================================
- Hits 2298 2287 -11
+ Misses 6 0 -6
Partials 0 0
|
|
No worries, thanks for the work here. Looks like I need to add one more test to get the coverage we need. I've got to switch to other things now so I'll come back here when I get some more time. |
…1023) test(Accordion): add inclusive tests for opening and closing panels
|
This may pass now, thanks to @koenvg writing some more tests. |
|
@levithomason - the build died on circle so I restarted it and looks like it passed. We g2g here? |
|
Released in |
DomiR
added a commit
to DomiR/Semantic-UI-React
that referenced
this pull request
Dec 19, 2016
* pr/2: docs(Sidebar): fix filenames fixes Semantic-Org#1048 docs(changelog): update changelog [ci skip] 0.62.3 feat(Checkbox): Indeterminate state (Semantic-Org#1043) Feat(typings): Added typings for Radio, Confirm, Select and Textarea (Semantic-Org#1047) chore(package): update babel-core to version 6.21.0 (Semantic-Org#1045) fix(dropdown): clear value when dropdown is blurred (Semantic-Org#1046) fix(typings): fix typings spelling on `Accordion` (Semantic-Org#1044) fix(docs): Fix check icon (Semantic-Org#1042) docs(changelog): update changelog [ci skip] 0.62.2 fix(Header): Remove duplicate class (Semantic-Org#1040) test(Examples): assert no console errors (Semantic-Org#645) feat(Accordion): ability to open multiple items (Semantic-Org#988) feat(docs): Active className on Sidebar item (Semantic-Org#1031) chore(package): update node-sass to version 4.0.0 (Semantic-Org#1015) chore(package): update debug to version 2.4.1 (Semantic-Org#1028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #976