Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Accordion): ability to open multiple items #499

Closed
brsanthu opened this issue Sep 15, 2016 · 4 comments
Closed

feat(Accordion): ability to open multiple items #499

brsanthu opened this issue Sep 15, 2016 · 4 comments
Labels
enhancement help wanted

Comments

@brsanthu
Copy link
Contributor

Can we support opening multiple content panels at a time?
@levithomason
Copy link
Member

I would merge a PR for that. SUI core calls this exclusive. In our case it might look like:

<Accordion exclusive={false} />

@layershifter layershifter changed the title Accordian: Ability to open multiple items Accordion: Ability to open multiple items Sep 15, 2016
@brsanthu
Copy link
Contributor Author

Can you please give some pointers on where to fix this?

@levithomason
Copy link
Member

levithomason commented Sep 15, 2016 •
edited
Loading

It would be in modifying src/modules/Accordion/Accordion.js. It currently accepts a single activeIndex value. That index is the index of the currently open panel. It would need to accept an array of indices. Then, every index in the array would correspond to an open panel.

@levithomason levithomason mentioned this issue Oct 4, 2016
Merged
9 tasks
@levithomason levithomason changed the title Accordion: Ability to open multiple items feat(Accordion): ability to open multiple items Oct 6, 2016
@levithomason
Copy link
Member

Fixed in #988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brsanthu @levithomason