Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Deprecate CDP methods on Firefox #14763

Merged
merged 3 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ module HasLogEvents
#

def on_log_event(kind, &block)
if browser == :firefox
WebDriver.logger.deprecate(
'Driver#on_log_event on Firefox',
'the script.add_console_message_handler or the script.add_javascript_error_handler methods',
id: :on_log_event
)
end
raise Error::WebDriverError, "Don't know how to handle #{kind} events" unless KINDS.include?(kind)

enabled = log_listeners[kind].any?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ module HasNetworkInterception
#

def intercept(&)
if browser == :firefox
WebDriver.logger.deprecate(
'Driver#intercept on Firefox',
'the new bidi.network.add_intercept method',
id: :intercept
)
end
@interceptor ||= DevTools::NetworkInterceptor.new(devtools)
@interceptor.intercept(&)
end
Expand Down
Loading