-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Deprecate CDP methods on Firefox #14763
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should provide a replacement implementation and mention it in deprecation.
For example,on_log_event
should be deprecated in favor of script.add_console_message_handler
/ script.add_javascript_error_handler
.
If we don't have exact replacements yet, I suggest we hold off deprecating the methods (suggestion per https://seleniumhq.slack.com/archives/CBH302726/p1731796745420569?thread_ts=1731576590.042029&cid=CBH302726).
Description
This PR adds deprecation warnings for all the CDP methods for Firefox
Example of deprecation warnings:
Motivation and Context
Based on https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/
We want to deprecate CDP methods on firefox and encourage Selenium users to use the new BiDi implementation
Types of changes
Checklist