Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Add CDP deprecation warning for Firefox #14759

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[dotnet] Add CDP deprecation warning for Firefox #14759

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fc56db
[dotnet] Add CDP deprecation warning for Firefox
pujagani Nov 15, 2024
3fd6526
Fix build and formatting
pujagani Nov 15, 2024
474bf17
Fix build
pujagani Nov 15, 2024
25d1f6e
Update dotnet/src/webdriver/Remote/RemoteWebDriver.cs
pujagani Nov 18, 2024
af41cb2
Merge branch 'trunk' into add-cdp-warning
pujagani Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dotnet/src/webdriver/Firefox/FirefoxDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ public DevToolsSession GetDevToolsSession(int devToolsProtocolVersion)
/// Creates a session to communicate with a browser using a Developer Tools debugging protocol.
/// </summary>
/// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
[Obsolete("CDP support for Firefox is deprecated and will be removed in future versions. Please switch to WebDriver BiDi.")]
public DevToolsSession GetDevToolsSession(DevToolsOptions options)
{
if (this.devToolsSession == null)
Expand Down
11 changes: 11 additions & 0 deletions dotnet/src/webdriver/Remote/RemoteWebDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
// under the License.
// </copyright>

using OpenQA.Selenium.Internal.Logging;
using OpenQA.Selenium.DevTools;
using System;
using System.Collections.Generic;
Expand Down Expand Up @@ -63,6 +64,8 @@ namespace OpenQA.Selenium.Remote
/// </example>
public class RemoteWebDriver : WebDriver, IDevTools, IHasDownloads
{
private readonly ILogger _logger = Log.GetLogger(typeof(RemoteWebDriver));
pujagani marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// The name of the Selenium grid remote DevTools end point capability.
/// </summary>
Expand Down Expand Up @@ -425,6 +428,14 @@ public ReadOnlyCollection<IWebElement> FindElementsByCssSelector(string cssSelec
/// <returns>The active session to use to communicate with the Developer Tools debugging protocol.</returns>
public DevToolsSession GetDevToolsSession()
{
if (this.Capabilities.GetCapability(BrowserName) == "firefox")
{
if (_logger.IsEnabled(LogEventLevel.Warn))
{
_logger.Warn("CDP support for Firefox is deprecated and will be removed in future versions. Please switch to WebDriver BiDi.");
}
}

return GetDevToolsSession(new DevToolsOptions() { ProtocolVersion = DevToolsSession.AutoDetectDevToolsProtocolVersion });
}

Expand Down
Loading