-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add CDP deprecation warning for Firefox #14759
Conversation
PR Reviewer Guide 🔍(Review updated until commit 25d1f6e)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 25d1f6e
Previous suggestions✅ Suggestions up to commit 0fc56db
|
Co-authored-by: Nikolay Borisenko <[email protected]>
Persistent review updated to latest commit 25d1f6e |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add a warning about Firefox CDP deprecation.
Motivation and Context
Allow users up to 2 versions to switch to BiDi and then remove the CDP support for Firefox.
Types of changes
Checklist
PR Type
enhancement, documentation
Description
Obsolete
attribute to theGetDevToolsSession
method inFirefoxDriver.cs
to warn about the deprecation of CDP support for Firefox.RemoteWebDriver.cs
to log warnings when CDP is used with Firefox, encouraging the switch to WebDriver BiDi.Changes walkthrough 📝
FirefoxDriver.cs
Add deprecation warning for Firefox CDP support
dotnet/src/webdriver/Firefox/FirefoxDriver.cs
Obsolete
attribute to theGetDevToolsSession
method.RemoteWebDriver.cs
Implement logging for Firefox CDP deprecation warning
dotnet/src/webdriver/Remote/RemoteWebDriver.cs
RemoteWebDriver
class.