Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Selenium Manager Should honor full browser version #13419

Closed
titusfortner opened this issue Jan 9, 2024 · 7 comments
Closed

[🐛 Bug]: Selenium Manager Should honor full browser version #13419

titusfortner opened this issue Jan 9, 2024 · 7 comments

Comments

@titusfortner
Copy link
Member

What happened?

If a user specifies a specific patch version of the browser and it is available, Selenium should download it.

How can we reproduce the issue?

"selenium-manager", "--browser", "chrome", "--browser-version", "120.0.6099.71", "--language-binding", "ruby", "--output", "mixed", "--debug"

Relevant log output

DEBUG	chromedriver not found in PATH
DEBUG	chrome detected at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
DEBUG	Running command: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version
DEBUG	Output: "Google Chrome 120.0.6099.199 "
DEBUG	Detected browser: chrome 120.0.6099.199
DEBUG	Required driver: chromedriver 120.0.6099.109
DEBUG	Discovering versions from https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json
DEBUG	Downloading chromedriver 120.0.6099.109 from https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/120.0.6099.109/mac-x64/chromedriver-mac-x64.zip
INFO	Driver path: /Users/titusfortner/.cache/selenium/chromedriver/mac-x64/120.0.6099.109/chromedriver
INFO	Browser path: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

Operating System

Mac

Selenium version

sm_mixed_output branch

What are the browser(s) and version(s) where you see this issue?

n/a

What are the browser driver(s) and version(s) where you see this issue?

n/a

Are you using Selenium Grid?

n/a

Copy link

github-actions bot commented Jan 9, 2024

@titusfortner, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented May 16, 2024

The decision to implement this was made during the Selenium Dev Summit in May 2024.

@diemol diemol moved this to High in Selenium Manager May 16, 2024
@titusfortner titusfortner added this to the Selenium 5.0 milestone May 20, 2024
@shbenzer
Copy link
Contributor

shbenzer commented Oct 17, 2024

Could someone advise me on this issue? I'm trying to learn exactly how selenium manager downloads the required binaries, but I cannot figure out where selenium manager is utilizing the get_chrome_milestone() method to pull the available versions

@bonigarcia
Copy link
Member

I created a PR for this: #14619.

@shbenzer For implementing it, the general logic for browser discovery needed to be changed. Also, the specific logic for filtering the the releases from the CfT endpoints was changed.

@shbenzer
Copy link
Contributor

Awesome!

bonigarcia added a commit that referenced this issue Nov 18, 2024
* [rust] Selenium Manager honors full browser version (#13419)

* [rust] Minor change related to variable name
@bonigarcia
Copy link
Member

Closed via #14619.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Selenium Manager Nov 18, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

4 participants