Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Selenium Manager combine driver-version and browser-version #13420

Closed
titusfortner opened this issue Jan 9, 2024 · 5 comments

Comments

@titusfortner
Copy link
Member

titusfortner commented Jan 9, 2024

Feature and motivation

Kind of along the lines of #13419
The functionality for these two should be the same now that Selenium manages both.
I don't think SM should support mixing different versions of browser & driver.

It should:

  1. Full version: Use/Get the exact version of browser & driver, error if it can't find it
  2. Major version:
    • If matches what is installed, use what is installed
    • If there is a later minor/patch version available than what is installed log a warning (Does this work with installed versions? Should "stable" always use the latest Stable CfT and not what is on the desktop by default?)
    • Download the latest major version driver/browser

Usage example

./selenium-manager --browser chrome --browser-version 120.0.6099.71

@diemol
Copy link
Member

diemol commented Jan 10, 2024

I am not sure this is needed. I think we will eventually have the binary released and users will just need the driver version part, for example when they want to automate browsers like Brave.

@titusfortner
Copy link
Member Author

I can see that use case, but then --driver-version should not include a browser_path in the output.

@bonigarcia
Copy link
Member

If you think in Chrome terms, the browser and driver versions are indeed related (both major values match). But Firefox and geckodriver uses different versioning schema, so that's a reason to have --driver-version, in my opinion. Regarding not including browser_path, I am not sure about that. Reporting the found browser can be helpful in creating a Selenium session, which is the final aim.

@diemol
Copy link
Member

diemol commented May 16, 2024

Implementing #13419 will implicitly implement this one. Therefore, I am closing it.

@diemol diemol closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

3 participants