-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Use Conda for CI and fix deprecations #64
Conversation
How does this do on Mac and Windows? |
FEniCS AFAIK is not supported on windows natively. It supposedly runs in WSL. I can test this later to confirm. I guess there should be a warning during the build step to notify users. |
OSX seems fine with Travis. |
Alright, seems fine with me if @ysimillides likes it. The main reason we switched to the Docker was because the original installation method was difficult to deal with. But if this is simpler, then yeah, awesome. Just put a warning for Windows. |
Hey everything looks really good to me! Just a minor issue, we might want to include the newer julia versions in the testing script. |
Yeah, that would probably be a good idea. I don't think it's blocking to this PR though. |
Thanks! I managed to slip in my |
This builds upon #63. The docker container used for CI was using Julia 0.6 so I adjusted it to now use Conda as well. In addition there are several deprecation fixes for PyCall.
There are some outstanding issues:
Should fix #61, #52, and help #28 and #12.