Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Precompilation #28

Open
ysimillides opened this issue Aug 16, 2017 · 4 comments
Open

Fix Precompilation #28

ysimillides opened this issue Aug 16, 2017 · 4 comments

Comments

@ysimillides
Copy link
Contributor

Currently, we do not precompile the FEniCS.jl package. This is due to a known error documented here https://github.com/JuliaPy/PyCall.jl#using-pycall-from-julia-modules .
The fix can be documented here https://gist.github.com/ysimillides/f7b6d01c646d1d13034ec1069eec4104 .
To implement the fix though, would require refactoring of a large segment of the code base, so I will leave this until September.

@PallHaraldsson
Copy link

PallHaraldsson commented Oct 13, 2017

I was reading https://julialang.org/blog/2017/09/gsoc-fenics and see:

  1. "Fixing precompilation which would provide a large performance benefit."

My understanding, is precompilation helps only with startup (but not general use after). If I'm right, and that's not a big deal, then maybe amend the too pessimistic wording in the interesting blog post?

  1. "initial partial different equations"

typo missing -al, right.

@ChrisRackauckas
Copy link
Member

If I'm right, and that's not a big deal, then maybe amend the too pessimistic wording in the interesting blog post?

You are correct. It should be re-worded to say it would help speed up initial calls but that's it.

@ysimillides
Copy link
Contributor Author

Hi Pall,

Thanks for the kind words. Once theres abit more of the package implemented, I'll see about updating / creating a new blog post, hopefully with a more positive tone :)

@clason
Copy link

clason commented Aug 20, 2018

Now that precompile is the default, it might make sense to explicitly mention this in the README, otherwise people will wonder (like I did) why FEniCS.jl keeps precompiling after every startup...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants