Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: infer initial schema #79

Merged
merged 5 commits into from
Jun 29, 2022
Merged

feat: infer initial schema #79

merged 5 commits into from
Jun 29, 2022

Conversation

MShahzaib
Copy link
Contributor

@MShahzaib MShahzaib commented Jun 23, 2022 •
edited by lars-reimann
Loading

Closes #12.

Summary of Changes

  • added Tablesaw for inferring the initial dataset schema
  • implemented schema inference for the initial dataset schema with a Unit test

@MShahzaib MShahzaib requested a review from lars-reimann as a code owner June 23, 2022 16:16
@MShahzaib MShahzaib changed the title Feat infer initial schema feat: Infer initial schema Jun 23, 2022
@MShahzaib
Copy link
Contributor Author

MShahzaib commented Jun 23, 2022 •
edited
Loading

@lars-reimann Please merge this after the PR 78

@github-actions
Copy link

github-actions bot commented Jun 23, 2022 •
edited
Loading

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.51s
✅ GIT git_diff yes no 0.01s
✅ KOTLIN ktlint 3 0 0 7.47s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann changed the title feat: Infer initial schema feat: infer initial schema Jun 23, 2022
lars-reimann
lars-reimann requested changes Jun 23, 2022
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have another look after #78 is merged.

...larsreimann.safeds/src/main/kotlin/com/larsreimann/safeds/validation/schema/SchemaChecker.kt Outdated Show resolved Hide resolved
...imann.safeds/src/main/kotlin/com/larsreimann/safeds/staticAnalysis/schema/SchemaInference.kt Outdated Show resolved Hide resolved
DSL/com.larsreimann.safeds/src/test/resources/schema/testDataset.csv Outdated Show resolved Hide resolved
@MShahzaib MShahzaib force-pushed the feat_Infer_initial_schema branch from 605d9fa to 3b9c225 Compare June 29, 2022 09:17
@MShahzaib MShahzaib force-pushed the feat_Infer_initial_schema branch from 3b9c225 to 08e7a4c Compare June 29, 2022 09:31
@lars-reimann lars-reimann merged commit e5f2a8c into main Jun 29, 2022
@lars-reimann lars-reimann deleted the feat_Infer_initial_schema branch June 29, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tool to infer initial schema of dataset
2 participants
@MShahzaib @lars-reimann